HBASE-29596 Migrate Canary Status Jamon page back to JSP

[PDavid]

This is the last step of the Jamon to JSP migration: the Canary Status page.

Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests.

Changed the Canary Server Status page back to /canary.jsp. Made sure that /canary-status redirects to /canary.jsp.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages.

Removed the Jamon Maven dependencies and references to Jamon code.

Signed-off-by: Istvan Toth [email protected]
Signed-off-by: Nihal Jain [email protected]
(cherry picked from commit 4ba9b46)

[PDavid]

This is a backport of #7390 to branch-3.
The cherry-pick applied almost cleanly, the only difference is that the master patch had a 1 line change in src/main/asciidoc/_chapters/developer.adoc but this file is not present in this branch (because we only kept and maintain the RefGuide in master).

Testing

Tested the patch the same way as described here: #7390 (comment)

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 23s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 58s		branch-3 passed
+1 💚	compile	14m 4s		branch-3 passed
+1 💚	checkstyle	2m 47s		branch-3 passed
+1 💚	spotbugs	14m 58s		branch-3 passed
+1 💚	spotless	1m 6s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 25s		the patch passed
+1 💚	compile	13m 51s		the patch passed
+1 💚	javac	13m 51s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 39s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	15m 27s		the patch passed
+1 💚	hadoopcheck	13m 27s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	1m 12s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 14s		The patch does not generate ASF License warnings.
		104m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7496
Optional Tests	dupname asflicense checkstyle javac codespell detsecrets xmllint spotless hadoopcheck compile spotbugs hbaseanti
uname	Linux c35c8898e627 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / e26d6ff
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	162 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 24s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 15s		branch-3 passed
+1 💚	compile	2m 7s		branch-3 passed
+1 💚	javadoc	3m 3s		branch-3 passed
+1 💚	shadedjars	6m 4s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	2m 11s		the patch passed
+1 💚	javac	2m 11s		the patch passed
+1 💚	javadoc	3m 2s		the patch passed
+1 💚	shadedjars	5m 59s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	281m 44s	/patch-unit-root.txt	root in the patch failed.
		320m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7496
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 26e0271e8a49 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / e26d6ff
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/testReport/
Max. process+thread count	7853 (vs. ulimit of 30000)
modules	C: hbase-checkstyle hbase-zookeeper hbase-resource-bundle hbase-server hbase-shaded . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7496/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

Some REST-related tests failed (TestGzipFilter, TestNamespacesInstanceResource, TestSchemaResource) but those are unrelated to the changes and they are locally successful.