Skip to content

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saintstack merged 1 commit into from
Nov 1, 2019
Merged

HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time #745

saintstack merged 1 commit into from
Nov 1, 2019

Conversation

@bitterfox
Copy link
Contributor

@bitterfox bitterfox commented Oct 22, 2019

@Apache-HBase
Copy link

Apache-HBase commented Oct 22, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 37s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
💚 mvninstall 7m 28s branch-1.3 passed
💚 compile 0m 16s branch-1.3 passed with JDK v1.8.0_232
💚 compile 0m 22s branch-1.3 passed with JDK v1.7.0_242
💚 checkstyle 0m 43s branch-1.3 passed
💚 shadedjars 2m 54s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 25s branch-1.3 passed with JDK v1.8.0_232
💚 javadoc 0m 24s branch-1.3 passed with JDK v1.7.0_242
💙 spotbugs 1m 36s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 1m 33s branch-1.3 passed
_ Patch Compile Tests _
💔 mvninstall 0m 47s root in the patch failed.
💔 compile 0m 11s hbase-client in the patch failed with JDK v1.8.0_232.
💔 javac 0m 11s hbase-client in the patch failed with JDK v1.8.0_232.
💔 compile 0m 13s hbase-client in the patch failed with JDK v1.7.0_242.
💔 javac 0m 13s hbase-client in the patch failed with JDK v1.7.0_242.
💚 checkstyle 0m 38s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💔 shadedjars 0m 55s patch has 14 errors when building our shaded downstream artifacts.
💔 hadoopcheck 0m 52s The patch causes 14 errors with Hadoop v2.4.1.
💔 hadoopcheck 1m 46s The patch causes 14 errors with Hadoop v2.5.2.
💔 hadoopcheck 2m 47s The patch causes 14 errors with Hadoop v2.6.5.
💔 hadoopcheck 3m 45s The patch causes 14 errors with Hadoop v2.7.7.
💔 javadoc 0m 10s hbase-client in the patch failed with JDK v1.8.0_232.
💔 javadoc 0m 12s hbase-client in the patch failed with JDK v1.7.0_242.
💔 findbugs 0m 14s hbase-client in the patch failed.
_ Other Tests _
💔 unit 0m 13s hbase-client in the patch failed.
💚 asflicense 0m 14s The patch does not generate ASF License warnings.
23m 33s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/Dockerfile
GITHUB PR #745
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 057fd2684dc8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-745/out/precommit/personality/provided.sh
git revision branch-1.3 / 80d1f62
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-compile-hbase-client-jdk1.8.0_232.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-compile-hbase-client-jdk1.8.0_232.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-compile-hbase-client-jdk1.7.0_242.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-compile-hbase-client-jdk1.7.0_242.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javac-2.4.1.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javac-2.5.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javac-2.6.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javac-2.7.7.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javadoc-hbase-client-jdk1.8.0_232.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-javadoc-hbase-client-jdk1.7.0_242.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-findbugs-hbase-client.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/artifact/out/patch-unit-hbase-client.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/testReport/
Max. process+thread count 77 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bitterfox bitterfox force-pushed the HBASE-23185-branch-1.3 branch from f76a9dd to b760319 Compare October 22, 2019 11:21
@Apache-HBase
Copy link

Apache-HBase commented Oct 22, 2019

🎊 +1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 33s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
💚 mvninstall 7m 31s branch-1.3 passed
💚 compile 0m 17s branch-1.3 passed with JDK v1.8.0_232
💚 compile 0m 22s branch-1.3 passed with JDK v1.7.0_242
💚 checkstyle 0m 43s branch-1.3 passed
💚 shadedjars 2m 52s branch has no errors when building our shaded downstream artifacts.
💚 javadoc 0m 27s branch-1.3 passed with JDK v1.8.0_232
💚 javadoc 0m 24s branch-1.3 passed with JDK v1.7.0_242
💙 spotbugs 1m 31s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 1m 28s branch-1.3 passed
_ Patch Compile Tests _
💚 mvninstall 1m 56s the patch passed
💚 compile 0m 16s the patch passed with JDK v1.8.0_232
💚 javac 0m 16s the patch passed
💚 compile 0m 22s the patch passed with JDK v1.7.0_242
💚 javac 0m 22s the patch passed
💚 checkstyle 0m 40s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💚 shadedjars 2m 45s patch has no errors when building our shaded downstream artifacts.
💚 hadoopcheck 10m 9s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
💚 javadoc 0m 18s the patch passed with JDK v1.8.0_232
💚 javadoc 0m 24s the patch passed with JDK v1.7.0_242
💚 findbugs 1m 35s the patch passed
_ Other Tests _
💚 unit 2m 5s hbase-client in the patch passed.
💚 asflicense 0m 14s The patch does not generate ASF License warnings.
37m 2s
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/2/artifact/out/Dockerfile
GITHUB PR #745
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 47d009dd513f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-745/out/precommit/personality/provided.sh
git revision branch-1.3 / 80d1f62
Default Java 1.7.0_242
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/2/testReport/
Max. process+thread count 115 (vs. ulimit of 10000)
modules C: hbase-client U: hbase-client
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-745/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@bitterfox
Copy link
Contributor Author

bitterfox commented Oct 23, 2019

not merge yet

@JeongDaeKim JeongDaeKim mentioned this pull request Oct 24, 2019
Closed
@saintstack saintstack merged commit 2a078fd into apache:branch-1.3 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bitterfox @Apache-HBase @saintstack