Skip to content

HBASE-29660 submittedRegionProcedures data leak in HRegionServer when… #7381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaijunjie0101 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

HBASE-29660 submittedRegionProcedures data leak in HRegionServer when… #7381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...erver/src/main/java/org/apache/hadoop/hbase/regionserver/handler/AssignRegionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ private void cleanUpAndReportFailure(IOException error) throws IOException {
throw new IOException(
"Failed to report failed open to master: " + regionInfo.getRegionNameAsString());
}
rs.finishRegionProcedure(openProcId);
}

@Override
Expand All @@ -109,6 +110,7 @@ public void process() throws IOException {
// but before returning to master the connection is broken. And when master tries again, we
// have already finished the opening. For this case we do not need to call
// reportRegionStateTransition any more.
rs.finishRegionProcedure(openProcId);
return;
}
Boolean previous = rs.getRegionsInTransitionInRS().putIfAbsent(encodedNameBytes, Boolean.TRUE);
Expand All @@ -117,6 +119,7 @@ public void process() throws IOException {
// The region is opening and this maybe a retry on the rpc call, it is safe to ignore it.
LOG.info("Receiving OPEN for {} which we are already trying to OPEN"
+ " - ignoring this new request for this region.", regionName);
rs.finishRegionProcedure(openProcId);
} else {
// The region is closing. This is possible as we will update the region state to CLOSED when
// calling reportRegionStateTransition, so the HMaster will think the region is offline,
Expand Down