HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 #7366

Apache9 · 2025-10-07T09:59:28Z

No description provided.

Copilot

Pull Request Overview

This PR refactors the JUnit resource checking functionality to support both JUnit 4 and JUnit 5, as part of HBASE-29637. The changes extract resource analyzer classes to a shared utility and implement resource checking in the existing JUnit 5 extension.

Extracted resource analyzer classes from ResourceCheckerJUnitListener into a new JUnitResourceCheckers utility class
Simplified ResourceCheckerJUnitListener to use the shared utility for resource analyzer setup
Added resource checking functionality to HBaseJupiterExtension for JUnit 5 tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ResourceCheckerJUnitListener.java	Refactored to use extracted utility class instead of embedded analyzers
JUnitResourceCheckers.java	New utility class containing all resource analyzer implementations
HBaseJupiterExtension.java	Enhanced with resource checking capabilities for test methods

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java

Apache-HBase · 2025-10-07T10:57:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 9s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	5m 37s		master passed
+1 💚	compile	0m 27s		master passed
+1 💚	javadoc	0m 24s		master passed
+1 💚	shadedjars	8m 24s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 0s		the patch passed
+1 💚	compile	0m 28s		the patch passed
+1 💚	javac	0m 28s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed
+1 💚	shadedjars	8m 10s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	4m 10s		hbase-common in the patch passed.
		37m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7366
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 00712a148d63 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5e4b129`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/1/testReport/
Max. process+thread count	228 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-07T11:04:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	5m 43s		master passed
+1 💚	compile	1m 2s		master passed
+1 💚	checkstyle	0m 22s		master passed
+1 💚	spotbugs	0m 48s		master passed
+1 💚	spotless	1m 9s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 55s		the patch passed
+1 💚	compile	1m 0s		the patch passed
+1 💚	javac	1m 0s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		the patch passed
+1 💚	spotbugs	0m 53s		the patch passed
+1 💚	hadoopcheck	15m 41s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	1m 0s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 14s		The patch does not generate ASF License warnings.
		44m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7366
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux d4655854c07a 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5e4b129`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	71 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hbase-common/src/test/java/org/apache/hadoop/hbase/JUnitResourceCheckers.java

hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java

Co-authored-by: Copilot <[email protected]>

Apache-HBase · 2025-10-07T13:55:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 11s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	5m 38s		master passed
+1 💚	compile	0m 28s		master passed
+1 💚	javadoc	0m 27s		master passed
+1 💚	shadedjars	8m 17s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 52s		the patch passed
+1 💚	compile	0m 27s		the patch passed
+1 💚	javac	0m 27s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed
+1 💚	shadedjars	7m 29s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	3m 57s		hbase-common in the patch passed.
		36m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7366
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux e671f13c3d6f 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `323ea9c`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/3/testReport/
Max. process+thread count	228 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-10-07T14:02:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	6m 22s		master passed
+1 💚	compile	1m 3s		master passed
+1 💚	checkstyle	0m 19s		master passed
+1 💚	spotbugs	0m 43s		master passed
+1 💚	spotless	1m 10s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 24s		the patch passed
+1 💚	compile	0m 59s		the patch passed
+1 💚	javac	0m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 21s		the patch passed
+1 💚	spotbugs	0m 58s		the patch passed
+1 💚	hadoopcheck	14m 41s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 54s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		43m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7366
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9a1808a349a0 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `323ea9c`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	71 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7366/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

stoty

+1 LGTM

Co-authored-by: Copilot <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit d8b1912)

Apache9 requested a review from Copilot October 7, 2025 09:59

Copilot AI reviewed Oct 7, 2025

View reviewed changes

hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java Outdated Show resolved Hide resolved

Apache9 requested a review from Copilot October 7, 2025 12:30

Copilot AI reviewed Oct 7, 2025

View reviewed changes

hbase-common/src/test/java/org/apache/hadoop/hbase/JUnitResourceCheckers.java Outdated Show resolved Hide resolved

hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseJupiterExtension.java Outdated Show resolved Hide resolved

Apache9 self-assigned this Oct 7, 2025

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5

323ea9c

Co-authored-by: Copilot <[email protected]>

Apache9 force-pushed the HBASE-29637 branch from 5be8599 to 323ea9c Compare October 7, 2025 13:02

Apache9 requested a review from stoty October 8, 2025 13:48

stoty approved these changes Oct 9, 2025

View reviewed changes

Apache9 merged commit d8b1912 into apache:master Oct 9, 2025
1 check passed

Apache9 added a commit that referenced this pull request Oct 9, 2025

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 (#7366)

8818f4d

Co-authored-by: Copilot <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit d8b1912)

Apache9 added a commit that referenced this pull request Oct 9, 2025

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 (#7366)

d747df4

Co-authored-by: Copilot <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit d8b1912)

Apache9 added a commit that referenced this pull request Oct 9, 2025

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 (#7366)

bf06f11

Co-authored-by: Copilot <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit d8b1912)

Apache9 added a commit that referenced this pull request Oct 9, 2025

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 (#7366)

5f63495

Co-authored-by: Copilot <[email protected]> Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit d8b1912)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 #7366

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 #7366

Uh oh!

Apache9 commented Oct 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

stoty left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 #7366

HBASE-29637 Implement ResourceCheckerJUnitListener for junit 5 #7366

Uh oh!

Conversation

Apache9 commented Oct 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

Apache-HBase commented Oct 7, 2025

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants