Skip to content

HBASE-29586 Setting hbase.oldwals.cleaner.thread.size to negative value will throw IllegalArgumentExce… #7293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guluo2016 merged 4 commits into from
Dec 18, 2025
+7 −0
Merged

HBASE-29586 Setting hbase.oldwals.cleaner.thread.size to negative value will throw IllegalArgumentExce… #7293

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d738311
HBASE-29586 Setting to negative value will throw IllegalArgumentExce…
wangxiangdong123 Sep 11, 2025
4673dba
HBASE-29586 Setting hbase.oldwals.cleaner.thread.size check
wangxiangdong123 Sep 11, 2025
acf11d4
fix HBASE-29586 the previous wal cleanerr
wangxiangdong123 Oct 11, 2025
c36cb16
HBASE-29586 Fix the info to debug
wangxiangdong123 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,13 @@ protected boolean validate(Path file) {
@Override
public void onConfigurationChange(Configuration conf) {
int newSize = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
if (newSize <= 0) {
LOG.warn(
Copy link
Contributor

@NihalJain NihalJain Dec 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe just put as debug. also maybe sync with impl at

hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java

Line 180 in 8b17149

if (newThreadCount < 1) {

"The configuration {} has been set to an invalid value {}, "
+ "the default value {} will be used, no need to update.",
OLD_WALS_CLEANER_THREAD_SIZE, newSize, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);
Copy link
Contributor

@Apache9 Apache9 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait a minute, here we just return, which means we will keep the old value, not use the default value?

return;
}
if (newSize == oldWALsCleaner.size()) {
LOG.debug(
"Size from configuration is the same as previous which " + "is {}, no need to update.",
Expand Down