HBASE-25338 Use ClassLoader of current class instead of thread context ClassLoader #6918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thankfully there is a workaround for this issue. By setting extra providers option to built-in providers, you may bypass the issue and load the built-in providers. For example: See here for more context. |
challenger71498
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Please add a new commit which modifies pom.xml so we can trigger tests for the whole project. We can remove it while merging. Thanks. |
Contributor
Author
You mean the root |
Contributor
Author
|
Just in case, also attaching the test result of my test project mentioned above to be sure that the edit resolves the issue. I made a custom build of hbase-client from branch-2.5, using hadoop 2, PR applied. Image 1 shows that the custom build resolves the problem. 
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Apache9
approved these changes
Apr 24, 2025
Contributor
|
Seems OK, please revert the commit which modifies pom.xml, I will merge it later. Thanks @challenger71498 |
This reverts commit 8663c3a.
Contributor
Author
|
@Apache9 Will this PR be backported to 2.x? Since the master branch is for 4.0 (which hasn’t been released yet), and I am currently using version 2.6.2, it would be great if this PR could be backported. |
Apache9
pushed a commit
that referenced
this pull request
Apr 25, 2025
…t ClassLoader (#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
Apache9
pushed a commit
that referenced
this pull request
Apr 25, 2025
…t ClassLoader (#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
Apache9
pushed a commit
that referenced
this pull request
Apr 25, 2025
…t ClassLoader (#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
Apache9
pushed a commit
that referenced
this pull request
Apr 25, 2025
…t ClassLoader (#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
Contributor
|
@challenger71498 Could you please reply on the jira so I can assign the jira to you? I've cherry-picked the patch to all active branches. Thanks for contributing! |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Sure, I just requested a Jira account by self-service portal. I will leave a comment after getting one :) |
Contributor
Author
|
💔 -1 overall
This message was automatically generated. |
mokai87
pushed a commit
to mokai87/hbase
that referenced
this pull request
Aug 7, 2025
…t ClassLoader (apache#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
sanjeet006py
pushed a commit
to sanjeet006py/hbase
that referenced
this pull request
Sep 26, 2025
…t ClassLoader (apache#6918) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit bd30367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When the
ServiceLoader::loadmethod is invoked with a single argument, it uses the contextClassLoaderof current thread(by callingThread.currentThread.getContextClassLoader()). (For definition, see here.)Under normal circumstances, this does not cause issues. But there is a problem if you try to:
URLClassLoader::loadClass)hbase-client)In my case, I encountered this problem while developing JDBC wrapper for hbase-shell.
If you load the class from the jar file, the
ClassLoaderof current thread is normally the class loader used to load the parent application.ClassLoaderis not adaquate toServiceLoaderat theSaslClientAuthenticationProviders.ServiceLoaderwith the "parent"ClassLoadercould not access the service info of the jar file(META-INF/services).I also attached the full stacktrace of the exception just in case.
Stacktrace
I could reproduce this issue with the repository which I made by myself in here. You could also look into it for more information.
Suggestion
As @AbilashR mentioned at the issue, this can be fixed by adding ClassLoader of current class explicitly to the parameter.
I have run the test locally and had no issues. Please let me know if there are more tests I should run.
I also tried to add a test case for this, but gave up since reproducing the issue is quite complicated.
Any opinions & suggestions are appriciated. Also, I don't have much experiences in Java, so feel free to make any corrections.
Thank you :)