Skip to content

Conversation

@charlesconnell
Copy link
Contributor

At present, ZstdByteBuffDecompressor is limited to decompressing from a direct ByteBuffer to another direct ByteBuffer, or from a heap ByteBuffer to another heap ByteBuffer. Following a change I contributed to the zstd-jni project, this limitation can be removed.

… as input and heap ByteBuffer as output, or vice versa
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@charlesconnell
Copy link
Contributor Author

Test failures are unrelated

<lz4.version>1.8.0</lz4.version>
<snappy.version>1.1.10.4</snappy.version>
<zstd-jni.version>1.5.5-2</zstd-jni.version>
<zstd-jni.version>1.5.7-2</zstd-jni.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that we expose these libraries to downstream applications.

@ndimiduk
Copy link
Member

I kicked off another build.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 14s master passed
+1 💚 compile 7m 56s master passed
+1 💚 checkstyle 1m 14s master passed
+1 💚 spotbugs 7m 43s master passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 3s the patch passed
+1 💚 compile 7m 55s the patch passed
+1 💚 javac 7m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 11s the patch passed
+1 💚 xmllint 0m 0s No new issues.
+1 💚 spotbugs 8m 0s the patch passed
+1 💚 hadoopcheck 11m 56s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 19s The patch does not generate ASF License warnings.
62m 36s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6806/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6806
JIRA Issue HBASE-29193
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless xmllint
uname Linux 732de22ded75 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f8660bd
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 191 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-zstd . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6806/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 48s master passed
+1 💚 compile 2m 46s master passed
+1 💚 javadoc 3m 4s master passed
+1 💚 shadedjars 7m 28s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 57s the patch passed
+1 💚 compile 2m 48s the patch passed
+1 💚 javac 2m 48s the patch passed
+1 💚 javadoc 2m 49s the patch passed
+1 💚 shadedjars 7m 15s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 327m 15s root in the patch passed.
369m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6806/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6806
JIRA Issue HBASE-29193
Optional Tests javac javadoc unit compile shadedjars
uname Linux d7b790fe93c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f8660bd
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6806/2/testReport/
Max. process+thread count 8146 (vs. ulimit of 30000)
modules C: hbase-compression/hbase-compression-zstd . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6806/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit e56e14b into apache:master Apr 17, 2025
1 check passed
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 17, 2025
… as input and heap ByteBuffer as output, or vice versa (#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
@ndimiduk ndimiduk deleted the HBASE-29193/ZstdByteBuffDecompressor-more-flexible branch April 17, 2025 15:09
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 22, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 22, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 22, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 23, 2025
… as input and heap ByteBuffer as output, or vice versa (#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 23, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 23, 2025
… as input and heap ByteBuffer as output, or vice versa (#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 23, 2025
… as input and heap ByteBuffer as output, or vice versa (#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
… as input and heap ByteBuffer as output, or vice versa (apache#6806)

Signed-off-by: Nick Dimiduk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants