Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Mar 6, 2025

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid
Copy link
Contributor Author

PDavid commented Mar 7, 2025

PR build failed because of tests but these test failures are unrelated.

@PDavid PDavid marked this pull request as ready for review March 7, 2025 08:28
@stoty
Copy link
Contributor

stoty commented Mar 7, 2025

The commit message should be the same as the original patch with (addendum) or (addendum: remove unneeded TODO) tacked to the end, @PDavid .

@PDavid PDavid changed the title [ADDENDUM] HBASE-29115 Remove unneeded TODO HBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO) Mar 7, 2025
@PDavid PDavid force-pushed the HBASE-29115-remove-todo branch from f2693fb to 1da1b99 Compare March 7, 2025 08:55
@PDavid
Copy link
Contributor Author

PDavid commented Mar 7, 2025

Forgot to remove this TODO in #6668.

I already checked and the static resources (JS, CSS, fonts) are not bundled in the HBase assembly tarballs, just forgot to remove the TODO. 🤦‍♂️

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 3s master passed
+1 💚 compile 8m 26s master passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 55s the patch passed
+1 💚 compile 11m 12s the patch passed
+1 💚 javac 11m 12s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 xmllint 0m 0s No new issues.
+1 💚 hadoopcheck 13m 51s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 1m 4s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 16s The patch does not generate ASF License warnings.
51m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6764/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6764
Optional Tests dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname Linux 4b498ea8e5bb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1da1b99
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 191 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6764/2/console
versions git=2.34.1 maven=3.9.8 xmllint=20913
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@petersomogyi
Copy link
Contributor

CI build likely failed due to the previous Yetus issue. Should be irrelevant in this comment removal.

@petersomogyi petersomogyi merged commit 756e22e into apache:master Mar 10, 2025
1 check failed
@PDavid PDavid deleted the HBASE-29115-remove-todo branch March 10, 2025 13:43
@PDavid
Copy link
Contributor Author

PDavid commented Mar 10, 2025

Many thanks for the reviews @stoty and @petersomogyi! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants