-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29115 Fix website cannot load some resources because of CSP (addendum: remove unneeded TODO) #6764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
PR build failed because of tests but these test failures are unrelated. |
|
The commit message should be the same as the original patch with (addendum) or (addendum: remove unneeded TODO) tacked to the end, @PDavid . |
…dendum: remove unneeded TODO)
f2693fb to
1da1b99
Compare
|
Forgot to remove this TODO in #6668. I already checked and the static resources (JS, CSS, fonts) are not bundled in the HBase assembly tarballs, just forgot to remove the TODO. 🤦♂️ |
|
🎊 +1 overall
This message was automatically generated. |
stoty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
|
CI build likely failed due to the previous Yetus issue. Should be irrelevant in this comment removal. |
|
Many thanks for the reviews @stoty and @petersomogyi! 🙏 |
No description provided.