Skip to content

HBASE-28832 Fixed TestInfoServersACL test #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NihalJain merged 1 commit into from
Jan 6, 2025
Merged

HBASE-28832 Fixed TestInfoServersACL test #6571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-server/src/test/java/org/apache/hadoop/hbase/http/TestInfoServersACL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public Void run() throws Exception {

@Test
public void testTableActionsAvailableForAdmins() throws Exception {
final String expectedAuthorizedContent = "Actions:";
Copy link
Contributor Author

@PDavid PDavid Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI page does not have the colon anymore because I converted it to a HTML heading (<h2>Actions<h2>).
Alternatively we could expect here the HTML tags as well (<h2>Actions<h2>) but this way we are not depending on the actual HTML tag - if they change in the future the test will still be green.

What do you think?

Copy link
Contributor

@NihalJain NihalJain Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

final String expectedAuthorizedContent = "Actions";
UserGroupInformation admin = UserGroupInformation
.loginUserFromKeytabAndReturnUGI(USER_ADMIN_STR, KEYTAB_FILE.getAbsolutePath());
admin.doAs(new PrivilegedExceptionAction<Void>() {
Expand Down