-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29005 Cannot split hbase:quota table when quota enforcement is enabled #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @droudnitsky |
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceStateManager.java
Outdated
Show resolved
Hide resolved
13e29cb to
4a6a514
Compare
| */ | ||
| @Category({ MiscTests.class, LargeTests.class }) | ||
| @RunWith(Parameterized.class) | ||
| public class TestSplitMergeQuotaTable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced scope of this test class to just cover the quota table. Previously It was for system tables and on branch-2 I was adding coverage for the namespace table. Turns out that we hard-code cannot split the namespace table, so that was futile.
|
|
||
| @Parameterized.Parameters(name = "{1}") | ||
| public static Object[][] params() { | ||
| return new Object[][] { { Map.of(QuotaUtil.QUOTA_CONF_KEY, "false") }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing both with and without the quotas feature enabled, so that we have confidence that someone who has temporarily disabled the feature is still able to operate on the table.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…enabled (#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (apache#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (apache#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (apache#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
…enabled (apache#6501) Signed-off-by: Bryan Beaudreault <[email protected]>
When quotas are enabled, splitting the quota table fails due to the namespace region quotas system being partially initialized.
See discussion on the dev list, https://lists.apache.org/thread/gdnjb1ys8m93lowykdrh4m7o55mgw3vo