HBASE-28634 Fix FuzzyRowFilter may not return data on reverse scans #6482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Changes:
- Reproduced the issue with a mini cluster test.
- Corrected reverse unit tests in TestFuzzyRowFilter as some expectations were not correct.
- Fixed hint returned by FuzzyRowFilter.getNextForFuzzyRule() in the reverse case:
- Before we only trimmed the trailing zeros from the hint in the forward scan case. From now on we also do this in the reverse case.
- Also extracted PrefixFilter.increaseLastNonMaxByte() method to PrivateCellUtil so that it can be reused in FuzzyRowFilter.
- When the hint should contain a 0xFF. As a start, when we have a reverse scan, we not only need trailing 0xff's instead of trailing 0x00's, but it seems we always need 0xff's instead of the 0x00's.
- Made some small improvements to FuzzyRowFilter which IntelliJ IDEA suggested (final fields, simplifications).
PDavid
force-pushed
the
HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2
branch
from
01cff22 to
c563552
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
PDavid
deleted the
HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2
branch
PDavid
restored the
HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2
branch
Contributor
Author
|
Sorry, I closed this by accident 😅 |
PDavid
deleted the
HBASE-28634-FuzzyRowFilter-reverse-no-data-branch-2
branch
stoty
pushed a commit
that referenced
this pull request
Nov 25, 2024
…6482) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 20e510f)
stoty
pushed a commit
that referenced
this pull request
Nov 25, 2024
…6482) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 20e510f)
mokai87
pushed a commit
to mokai87/hbase
that referenced
this pull request
Aug 7, 2025
…pache#6482) Signed-off-by: Istvan Toth <[email protected]>
sanjeet006py
pushed a commit
to sanjeet006py/hbase
that referenced
this pull request
Sep 26, 2025
…pache#6482) Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 20e510f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backport of #6457 to
branch-2Changes:
TestFuzzyRowFilteras some expectations were not correct.FuzzyRowFilter.getNextForFuzzyRule()in the reverse case:PrefixFilter.increaseLastNonMaxByte()method toPrivateCellUtilso that it can be reused inFuzzyRowFilter.0xFF. As a start, when we have a reverse scan, we not only need trailing0xff's instead of trailing0x00's, but it seems we always need0xff's instead of the0x00's.FuzzyRowFilterwhich IntelliJ IDEA suggested (final fields, simplifications).