Skip to content

HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCache.freespace #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wchevreuil merged 3 commits into from
Oct 30, 2024
Merged

HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCache.freespace #6373

wchevreuil merged 3 commits into from
Oct 30, 2024

Conversation

@wchevreuil
Copy link
Contributor

@wchevreuil wchevreuil commented Oct 18, 2024

No description provided.

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
41a9744 
…e.freespace

Change-Id: Id3c9c7d3fdbdd2ca21d55b53d1743fe31a77d4ea
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@wchevreuil
pruning some lines due to checkstyles
95f7c96 
Change-Id: Id96f80df1266ae8251ae881fcef2b183c5c01a64
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
vinayakphegde
vinayakphegde reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@vinayakphegde vinayakphegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! added one comment. not very important though!

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java Outdated
private static final boolean STRONG_REF_DEFAULT = false;

/** The cache age of blocks to check if the related file is present on any online regions. */
static final String BLOCK_ORPHAN_GRACE_PERIOD = "hbase.bucketcache.block.orphan.evictgraceperiod";
Copy link
Contributor

@vinayakphegde vinayakphegde Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since this configuration is in seconds, can we define it directly in the config, as we usually do? Something like "hbase.bucketcache.block.orphan.evictgraceperiod.seconds".

Kota-SH
Kota-SH approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Kota-SH Kota-SH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wchevreuil
addressing constant name suggestions
5e39188 
Change-Id: I34f6f19f09343423122575ea40e79e1ef19017b3
@wchevreuil wchevreuil merged commit d2c0350 into apache:master Oct 30, 2024
wchevreuil added a commit that referenced this pull request Oct 30, 2024
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
f7558f7 
…e.freespace (#6373)

Signed-off-by: Ankit Singhal <[email protected]>
Reviewed by: Kota-SH <[email protected]>
Reviewed by: Vinayak Hegde  <[email protected]>
@Apache-HBase
Copy link

Apache-HBase commented Oct 30, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 2m 58s master passed
+1 💚 compile 2m 57s master passed
+1 💚 checkstyle 0m 38s master passed
+1 💚 spotbugs 1m 36s master passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 49s the patch passed
+1 💚 compile 3m 19s the patch passed
+1 💚 javac 3m 19s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 spotbugs 2m 14s the patch passed
+1 💚 hadoopcheck 12m 8s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 52s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
38m 33s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6373
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 433849435f21 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e39188
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Oct 30, 2024
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
54bb187 
…e.freespace (apache#6373)

Signed-off-by: Ankit Singhal <[email protected]>
Reviewed by: Kota-SH <[email protected]>
Reviewed by: Vinayak Hegde  <[email protected]>
Change-Id: Ide3eb5573dc2ef16e60435181a688dbfa6b6177a
@Apache-HBase
Copy link

Apache-HBase commented Oct 30, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 36s master passed
+1 💚 compile 1m 1s master passed
+1 💚 javadoc 0m 37s master passed
+1 💚 shadedjars 5m 57s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 51s the patch passed
+1 💚 compile 0m 57s the patch passed
+1 💚 javac 0m 57s the patch passed
+1 💚 javadoc 0m 30s the patch passed
+1 💚 shadedjars 5m 20s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 224m 9s hbase-server in the patch passed.
250m 25s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6373
Optional Tests javac javadoc unit compile shadedjars
uname Linux ef782f6a8bc5 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5e39188
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/testReport/
Max. process+thread count 4568 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6373/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil added a commit that referenced this pull request Oct 31, 2024
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
ec9073c 
…e.freespace (#6373) (#6416)

Reviewed by: Kota-SH <[email protected]>
Reviewed by: Vinayak Hegde  <[email protected]>
Signed-off-by: Ankit Singhal <[email protected]>
wchevreuil added a commit that referenced this pull request Oct 31, 2024
@wchevreuil
HBASE-28923 Prioritize "orphan" blocks for eviction inside BucketCach…
037c4d8 
…e.freespace (#6373) (#6416)

Reviewed by: Kota-SH <[email protected]>
Reviewed by: Vinayak Hegde  <[email protected]>
Signed-off-by: Ankit Singhal <[email protected]>
Change-Id: Ic1b4cb24b2f395488cd76bf34538f725e9fd1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitsinghal ankitsinghal ankitsinghal approved these changes

@anmolnar anmolnar Awaiting requested review from anmolnar

@petersomogyi petersomogyi Awaiting requested review from petersomogyi

@taklwu taklwu Awaiting requested review from taklwu

+2 more reviewers

@vinayakphegde vinayakphegde vinayakphegde left review comments

@Kota-SH Kota-SH Kota-SH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wchevreuil @Apache-HBase @ankitsinghal @Kota-SH @vinayakphegde