Skip to content

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stoty merged 15 commits into from
Nov 6, 2024
Merged

HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT #6361

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
42ca0cf
HBASE-28621 PrefixFilter should use SEEK_NEXT_USING_HINT
Oct 8, 2024
45d5cbf
HBASE-28621 Removed unused field from TestPrefixFilter
Oct 10, 2024
3280f9f
HBASE-28621 PrefixFilter should also provide hint on reversed scans
PDavid Oct 15, 2024
75fd8fa
HBASE-28621 PrefixFilter now implements HintingFilter marker interface
PDavid Oct 15, 2024
870e9b6
HBASE-28621 Added unit test for PrefixFilter with mini cluster
PDavid Oct 18, 2024
a9db7da
HBASE-28621 Fixed PrefixFilter hint with reverse scans
PDavid Oct 24, 2024
0da2505
HBASE-28621 Added unit test for shorter rowKey than prefix length
PDavid Oct 24, 2024
2792fb2
HBASE-28621 Make sure PrefixFilter.filterRow() returns true even when…
PDavid Oct 29, 2024
31f34b4
HBASE-28621 Pre-compute reverse hint at creation
PDavid Oct 29, 2024
5779bd4
HBASE-28621 Restored some tests in TestPrefixFilter related to WhileM…
PDavid Oct 30, 2024
3225197
HBASE-28621 Moved hint-related methods before the serialization-relat…
PDavid Oct 30, 2024
039c896
HBASE-28621 Also pre-compute forward hint at PrefixFilter creation
PDavid Oct 30, 2024
ce46c31
HBASE-28621 Fixed TestFilterList.testMPONE() unit test
PDavid Oct 30, 2024
1aa84f5
HBASE-28621 Adjusted comment about behavior of PrefixFilter.filterRow…
PDavid Oct 30, 2024
ba21710
HBASE-28621 Fixed comment: use before/after
PDavid Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,9 @@ public boolean filterRowKey(Cell firstRowCell) {
if (filterAllRemaining()) {
return true;
}
// if the cell is smaller => return false so that getNextCellHint() is invoked.
// if they are equal, return false => pass row
// else return true, filter row
// if the cell is bigger => return true, filter row
// if we are passed the prefix, set flag
int cmp;
if (firstRowCell instanceof ByteBufferExtendedCell) {
Expand Down