Skip to content

HBASE-28868 Add missing permission check for updateRSGroupConfig in b… #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NihalJain merged 1 commit into from
Sep 23, 2024
Merged

HBASE-28868 Add missing permission check for updateRSGroupConfig in b… #6277

NihalJain merged 1 commit into from
Sep 23, 2024

Conversation

@NihalJain
Copy link
Contributor

@NihalJain NihalJain commented Sep 20, 2024

…ranch-2

@Apache-HBase
Copy link

Apache-HBase commented Sep 20, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 43s branch-2 passed
+1 💚 compile 0m 15s branch-2 passed
+1 💚 javadoc 0m 15s branch-2 passed
+1 💚 shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 26s the patch passed
+1 💚 compile 0m 15s the patch passed
+1 💚 javac 0m 15s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedjars 5m 16s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 3m 35s hbase-rsgroup in the patch passed.
22m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #6277
Optional Tests javac javadoc unit compile shadedjars
uname Linux 532da36907c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0269d9f
Default Java Temurin-1.8.0_412-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/testReport/
Max. process+thread count 2362 (vs. ulimit of 30000)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 20, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 2s branch-2 passed
+1 💚 compile 0m 21s branch-2 passed
+1 💚 javadoc 0m 16s branch-2 passed
+1 💚 shadedjars 5m 33s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 javadoc 0m 16s the patch passed
+1 💚 shadedjars 5m 31s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 3m 37s hbase-rsgroup in the patch passed.
23m 46s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6277
Optional Tests javac javadoc unit compile shadedjars
uname Linux 297cfe6303f2 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0269d9f
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/testReport/
Max. process+thread count 2520 (vs. ulimit of 30000)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 20, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 22s branch-2 passed
+1 💚 compile 0m 19s branch-2 passed
+1 💚 javadoc 0m 14s branch-2 passed
+1 💚 shadedjars 6m 10s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 0m 19s the patch passed
+1 💚 javac 0m 19s the patch passed
+1 💚 javadoc 0m 13s the patch passed
+1 💚 shadedjars 6m 6s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 4m 26s hbase-rsgroup in the patch passed.
26m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #6277
Optional Tests javac javadoc unit compile shadedjars
uname Linux 6021df5a55b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0269d9f
Default Java Eclipse Adoptium-11.0.23+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/testReport/
Max. process+thread count 2462 (vs. ulimit of 30000)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 20, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 26s branch-2 passed
+1 💚 compile 0m 29s branch-2 passed
+1 💚 checkstyle 0m 12s branch-2 passed
+1 💚 spotbugs 0m 33s branch-2 passed
+1 💚 spotless 1m 0s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 13s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 11s the patch passed
+1 💚 spotbugs 0m 38s the patch passed
+1 💚 hadoopcheck 15m 24s Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
28m 57s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6277
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 7970882c7f41 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0269d9f
Default Java Eclipse Adoptium-11.0.23+9
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-rsgroup U: hbase-rsgroup
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6277/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain NihalJain merged commit cf9c1d5 into apache:branch-2 Sep 23, 2024
NihalJain added a commit to NihalJain/hbase that referenced this pull request Sep 23, 2024
@NihalJain
HBASE-28868 Add missing permission check for updateRSGroupConfig in b…
790ffa6 
…ranch-2 (apache#6277)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit cf9c1d5)
@NihalJain NihalJain mentioned this pull request Sep 23, 2024
Merged
NihalJain added a commit to NihalJain/hbase that referenced this pull request Sep 23, 2024
@NihalJain
HBASE-28868 Add missing permission check for updateRSGroupConfig in b…
204fe2d 
…ranch-2 (apache#6277)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit cf9c1d5)
@NihalJain NihalJain mentioned this pull request Sep 23, 2024
Closed
NihalJain added a commit that referenced this pull request Sep 24, 2024
@NihalJain
HBASE-28868 Add missing permission check for updateRSGroupConfig in b…
bfe5c88 
…ranch-2 (#6277) (#6281)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit cf9c1d5)
NihalJain added a commit to NihalJain/hbase that referenced this pull request Sep 24, 2024
@NihalJain
HBASE-28868 Add missing permission check for updateRSGroupConfig in b…
a353ad3 
…ranch-2 (apache#6277)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit cf9c1d5)
@NihalJain NihalJain mentioned this pull request Sep 24, 2024
Merged
NihalJain added a commit that referenced this pull request Sep 24, 2024
@NihalJain
HBASE-28868 Add missing permission check for updateRSGroupConfig in b…
1a0d069 
…ranch-2 (#6277) (#6293)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit cf9c1d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NihalJain @Apache-HBase @Apache9