Skip to content

HBASE-28811 Use region server configuration for evicting the cache wh… #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wchevreuil merged 1 commit into from
Sep 6, 2024
Merged

HBASE-28811 Use region server configuration for evicting the cache wh… #6197

wchevreuil merged 1 commit into from
Sep 6, 2024

Conversation

@ragarkar
Copy link
Contributor

@ragarkar ragarkar commented Sep 4, 2024

…ile unassigning a region

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 3s master passed
+1 💚 compile 3m 0s master passed
+1 💚 checkstyle 0m 38s master passed
+1 💚 spotbugs 1m 37s master passed
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 3m 2s the patch passed
+1 💚 javac 3m 2s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 36s /results-checkstyle-hbase-server.txt hbase-server: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 💚 spotbugs 1m 39s the patch passed
+1 💚 hadoopcheck 10m 36s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
-1 ❌ spotless 0m 38s patch has 63 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
35m 49s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6197
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 35ed6fc47e5a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c288161
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 59s master passed
+1 💚 compile 0m 59s master passed
+1 💚 javadoc 0m 30s master passed
+1 💚 shadedjars 5m 22s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 55s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 javadoc 0m 29s the patch passed
+1 💚 shadedjars 5m 19s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 226m 23s hbase-server in the patch passed.
251m 28s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6197
Optional Tests javac javadoc unit compile shadedjars
uname Linux 0c330eb4e6ca 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c288161
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/testReport/
Max. process+thread count 5956 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 32s master passed
+1 💚 compile 4m 1s master passed
+1 💚 checkstyle 0m 45s master passed
+1 💚 spotbugs 1m 51s master passed
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 3m 57s the patch passed
+1 💚 javac 3m 57s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 47s the patch passed
+1 💚 spotbugs 1m 58s the patch passed
+1 💚 hadoopcheck 11m 41s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
42m 8s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6197
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux e3bcc601def3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 016ed65
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add UT for the changed behaviour? Something similar to TestSplitWithCache, but start with a given value for evictOnClose, change it for RSes only, trigger a region close, check the cache:

  1. Set evictOnClose to false:
    UTIL.getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, false);
  2. Start cluster:
    UTIL.startMiniCluster(1);
  3. Change the config for the RS only:
    UTIL.getMiniHBaseCluster().getRegionServer(0).getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, true);
  4. Disable table:
    UTIL.getAdmin().disableTable();
  5. Check blocks got evicted:

...ver/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java Outdated
private void closeRegionAfterUpdatingMeta(MasterProcedureEnv env, RegionStateNode regionNode) {
CloseRegionProcedure closeProc =
LOG.debug("Close region: isSplit: {}: evictOnClose: {}", isSplit,
isSplit
Copy link
Contributor

@wchevreuil wchevreuil Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this log is misleading, we should just pass the evictCache valure for evictOnClose.

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 30s master passed
+1 💚 compile 1m 34s master passed
+1 💚 javadoc 0m 47s master passed
+1 💚 shadedjars 7m 9s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 compile 1m 17s the patch passed
+1 💚 javac 1m 17s the patch passed
+1 💚 javadoc 0m 42s the patch passed
+1 💚 shadedjars 6m 3s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 258m 5s hbase-server in the patch passed.
289m 43s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6197
Optional Tests javac javadoc unit compile shadedjars
uname Linux a0ba97b39097 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 016ed65
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/testReport/
Max. process+thread count 5336 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 15s master passed
+1 💚 compile 3m 6s master passed
+1 💚 checkstyle 0m 35s master passed
+1 💚 spotbugs 1m 35s master passed
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 2s the patch passed
+1 💚 compile 3m 6s the patch passed
+1 💚 javac 3m 6s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 36s the patch passed
+1 💚 spotbugs 1m 40s the patch passed
+1 💚 hadoopcheck 11m 43s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
37m 50s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6197
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 20783683072d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 578ca4d
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 4, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 1s master passed
+1 💚 compile 0m 59s master passed
+1 💚 javadoc 0m 29s master passed
+1 💚 shadedjars 5m 23s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 javadoc 0m 31s the patch passed
+1 💚 shadedjars 5m 23s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 231m 10s hbase-server in the patch passed.
256m 8s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6197
Optional Tests javac javadoc unit compile shadedjars
uname Linux fa5d4ce7a853 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 578ca4d
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/testReport/
Max. process+thread count 4906 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ragarkar
Copy link
Contributor Author

ragarkar commented Sep 5, 2024

Can we add UT for the changed behaviour? Something similar to TestSplitWithCache, but start with a given value for evictOnClose, change it for RSes only, trigger a region close, check the cache:

  1. Set evictOnClose to false:
    UTIL.getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, false);
  2. Start cluster:
    UTIL.startMiniCluster(1);
  3. Change the config for the RS only:
    UTIL.getMiniHBaseCluster().getRegionServer(0).getConfiguration().setBoolean(EVICT_BLOCKS_ON_CLOSE_KEY, true);
  4. Disable table:
    UTIL.getAdmin().disableTable();
  5. Check blocks got evicted:

Added the unit test TestUseRSCacheConfigWhileClosingRegion.java

wchevreuil
wchevreuil requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UT seems correct, but let's refrain from duplicating code whenever possible. Please move these new tests to TestSplitWithCache, and reuse as much of the code from there.

@ragarkar
Copy link
Contributor Author

ragarkar commented Sep 5, 2024

The UT seems correct, but let's refrain from duplicating code whenever possible. Please move these new tests to TestSplitWithCache, and reuse as much of the code from there.

Refactored the unit test and renamed TestSplitWithCache to TestCacheEviction. The new test can be used to test other eviction scenarios in the future.

@Apache-HBase
Copy link

Apache-HBase commented Sep 5, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 3m 0s master passed
+1 💚 checkstyle 0m 39s master passed
+1 💚 spotbugs 1m 34s master passed
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 42s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 1m 41s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 ⚠️ javac 1m 41s /patch-compile-hbase-server.txt hbase-server in the patch failed.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 35s the patch passed
-1 ❌ spotbugs 0m 49s /patch-spotbugs-hbase-server.txt hbase-server in the patch failed.
-1 ❌ hadoopcheck 2m 1s The patch causes 16 errors with Hadoop v3.3.6.
-1 ❌ hadoopcheck 4m 3s The patch causes 16 errors with Hadoop v3.4.0.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
20m 34s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6197
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 12d3f4abfab2 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87759d0
Default Java Eclipse Adoptium-17.0.11+9
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 5, 2024

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 45s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 1m 11s master passed
+1 💚 javadoc 0m 35s master passed
+1 💚 shadedjars 6m 50s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
-1 ❌ mvninstall 2m 11s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 1m 10s /patch-compile-hbase-server.txt hbase-server in the patch failed.
-0 ⚠️ javac 1m 10s /patch-compile-hbase-server.txt hbase-server in the patch failed.
+1 💚 javadoc 0m 34s the patch passed
-1 ❌ shadedjars 5m 20s patch has 16 errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 1m 19s /patch-unit-hbase-server.txt hbase-server in the patch failed.
24m 55s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6197
Optional Tests javac javadoc unit compile shadedjars
uname Linux adde2e4b6722 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 87759d0
Default Java Eclipse Adoptium-17.0.11+9
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/testReport/
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 6, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 0s master passed
+1 💚 compile 2m 58s master passed
+1 💚 checkstyle 0m 38s master passed
+1 💚 spotbugs 1m 34s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 2m 58s the patch passed
+1 💚 javac 2m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 38s the patch passed
+1 💚 spotbugs 1m 41s the patch passed
+1 💚 hadoopcheck 10m 21s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
35m 26s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6197
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux ecef815891c3 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8955e45
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 6, 2024

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 2s master passed
+1 💚 compile 0m 57s master passed
+1 💚 javadoc 0m 31s master passed
+1 💚 shadedjars 5m 16s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 javadoc 0m 28s the patch passed
+1 💚 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 236m 11s hbase-server in the patch passed.
260m 30s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6197
Optional Tests javac javadoc unit compile shadedjars
uname Linux 9ffbb5282671 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8955e45
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/testReport/
Max. process+thread count 5388 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6197/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit 888e4dd into apache:master Sep 6, 2024
wchevreuil pushed a commit that referenced this pull request Sep 6, 2024
@ragarkar @wchevreuil
HBASE-28811 Use region server configuration for evicting the cache wh…
7bce8e6 
…ile unassigning a region (#6197)

Signed-off-by: Wellington Chevreuil <[email protected]>
ragarkar added a commit to ragarkar/hbase that referenced this pull request Sep 7, 2024
@ragarkar
HBASE-28811 Use region server configuration for evicting the cache wh…
cb59bee 
…ile unassigning a region (apache#6197)

Signed-off-by: Wellington Chevreuil <[email protected]>
(cherry picked from commit 888e4dd)
@ragarkar ragarkar mentioned this pull request Sep 7, 2024
Merged
wchevreuil pushed a commit that referenced this pull request Sep 9, 2024
@ragarkar
HBASE-28811 Use region server configuration for evicting the cache wh…
6669e3c 
…ile unassigning a region (#6197) (#6217)

Signed-off-by: Wellington Chevreuil <[email protected]>
(cherry picked from commit 888e4dd)
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Feb 7, 2025
@ragarkar
CDPD-74150: Backport HBASE-28811 Use region server configuration for …
c4423a4 
…evicting the cache while unassigning a region (apache#6197)

Signed-off-by: Wellington Chevreuil <[email protected]>
(cherry picked from commit 888e4dd)
stoty pushed a commit to stoty/hbase that referenced this pull request Nov 22, 2025
@ragarkar
CDPD-74150: Backport HBASE-28811 Use region server configuration for …
57a98da 
…evicting the cache while unassigning a region (apache#6197)

Signed-off-by: Wellington Chevreuil <[email protected]>
(cherry picked from commit 888e4dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ragarkar @Apache-HBase @wchevreuil