Skip to content

HBASE-28643 An unbounded backup failure message can cause an irrecoverable state for the given backup #6088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndimiduk merged 3 commits into from
Sep 2, 2024
Merged

HBASE-28643 An unbounded backup failure message can cause an irrecoverable state for the given backup #6088

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a0d771
HBASE-28643 Limit BackupInfo failure message length
Jul 17, 2024
0b66295
Ensure lost BackupInfo updates manifest as a failure
Jul 17, 2024
2cd3a22
rm unhelpful error handling
Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
@InterfaceAudience.Private
public class BackupInfo implements Comparable<BackupInfo> {
private static final Logger LOG = LoggerFactory.getLogger(BackupInfo.class);
private static final int MAX_FAILED_MESSAGE_LENGTH = 1024;

public interface Filter {
/**
Expand Down Expand Up @@ -253,6 +254,9 @@ public String getFailedMsg() {
}

public void setFailedMsg(String failedMsg) {
if (failedMsg.length() > MAX_FAILED_MESSAGE_LENGTH) {
failedMsg = failedMsg.substring(0, MAX_FAILED_MESSAGE_LENGTH);
}
this.failedMsg = failedMsg;
}

Expand Down
14 changes: 13 additions & 1 deletion hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,19 @@ public void updateBackupInfo(BackupInfo info) throws IOException {
}
try (Table table = connection.getTable(tableName)) {
Put put = createPutForBackupInfo(info);
table.put(put);
try {
table.put(put);
} catch (Exception e) {
// If the BackupInfo update can't be processed, then we should fall back to
// the previous BackupInfo, but also update it to reflect the failure.
LOG.error("Failed to update BackupInfo for {}. Marking as failed", info.getBackupId(), e);
BackupInfo legacyInfo = readBackupInfo(info.getBackupId());
if (legacyInfo != null) {
legacyInfo.setFailedMsg("Failed to update BackupInfo. Error: " + e.getMessage());
table.put(createPutForBackupInfo(legacyInfo));
}
throw e;
}
}
}

Expand Down