-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28642 Hide old PR comments when posting new #5967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fdf451e to
d881732
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d881732 to
4f3adb1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4f3adb1 to
20357e8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e56b870 to
f3ad29e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR is now automatically hiding its own old comments :D |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see. |
I've been using a version of this script locally for all PRs i've reviewed since around April. It's never hidden a wrong comment by mistake. Indeed, you see that the commit author is hard-coded. |
f81c92d to
3a5335e
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
I looked at GitHub's GraphQL API docs and unfortunately it doesn't support mutations over filters. The API has the following input fields:
The |
petersomogyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lifesaver! :) Thanks @ndimiduk!
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>
It would be really nice if the build bot would hide the old commits when it posts new ones. When a PR has been open for a while, we end up with more build-bot activity than human activity and it's easy to lose human comments.