Skip to content

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 6, 2024

It would be really nice if the build bot would hide the old commits when it posts new ones. When a PR has been open for a while, we end up with more build-bot activity than human activity and it's easy to lose human comments.

@ndimiduk ndimiduk force-pushed the 28642-hide-old-pr-comments branch from fdf451e to d881732 Compare June 6, 2024 12:51
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk force-pushed the 28642-hide-old-pr-comments branch from d881732 to 4f3adb1 Compare June 12, 2024 08:20
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk force-pushed the 28642-hide-old-pr-comments branch from 4f3adb1 to 20357e8 Compare September 11, 2024 13:19
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk force-pushed the 28642-hide-old-pr-comments branch from e56b870 to f3ad29e Compare September 12, 2024 08:34
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk
Copy link
Member Author

This PR is now automatically hiding its own old comments :D

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain
Copy link
Contributor

This PR is now automatically hiding its own old comments :D

Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see.

@ndimiduk
Copy link
Member Author

This PR is now automatically hiding its own old comments :D

Hey @ndimiduk thanks for this nice fix. LGTM, added some nits. This will make PRs comments very clean. Just to test the case that it does not hide actual user comment (which seems to be handled in code already), can we do a dummy build and see.

I've been using a version of this script locally for all PRs i've reviewed since around April. It's never hidden a wrong comment by mistake. Indeed, you see that the commit author is hard-coded.

@ndimiduk ndimiduk force-pushed the 28642-hide-old-pr-comments branch from f81c92d to 3a5335e Compare September 17, 2024 08:41
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
-0 ⚠️ patch 0m 13s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
1m 34s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5967
Optional Tests
uname Linux 1f8e83ab18ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3a5335e
Max. process+thread count 42 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
-0 ⚠️ patch 0m 43s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
3m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5967
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless
uname Linux 543d4b7730a7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3a5335e
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5967/18/console
versions git=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@aalhour
Copy link
Contributor

aalhour commented Sep 17, 2024

I looked at GitHub's GraphQL API docs and unfortunately it doesn't support mutations over filters. The API has the following input fields:

  1. classifier (ReportedContentClassifiers!)
  2. clientMutationId (String)
  3. subjectId (ID!)

The ! character in the type definition denotes a required field, which means you need to pass the commentID (subjectID) with each API call, if you want to use the API you'll have to fetch all comments and then iterate over all of them minimizing them one by one (N+1 API calls).

Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lifesaver! :) Thanks @ndimiduk!

@ndimiduk ndimiduk merged commit 125b502 into apache:master Sep 17, 2024
@ndimiduk ndimiduk deleted the 28642-hide-old-pr-comments branch September 17, 2024 10:50
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Sep 25, 2024
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
ndimiduk added a commit that referenced this pull request Sep 25, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Peter Somogyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants