HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering #5809

vinayakphegde · 2024-04-09T16:37:03Z

No description provided.

…t-cache (apache#5793) Signed-off-by: Wellington Chevreuil <[email protected]>

Apache-HBase · 2024-04-09T17:24:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	3m 16s	HBASE-28463 passed
+1 💚	compile	2m 59s	HBASE-28463 passed
+1 💚	checkstyle	0m 37s	HBASE-28463 passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 33s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	2m 40s	the patch passed
-0 ⚠️	javac	2m 40s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 49s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 27s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 51s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		34m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3d1875144a73 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-09T21:10:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	2m 47s	HBASE-28463 passed
+1 💚	compile	0m 39s	HBASE-28463 passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	236m 46s	hbase-server in the patch failed.
		259m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7b4a7f02d324 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/
Max. process+thread count	5510 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-09T21:31:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	3m 4s	HBASE-28463 passed
+1 💚	compile	0m 49s	HBASE-28463 passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 50s	the patch passed
+1 💚	compile	0m 50s	the patch passed
+1 💚	javac	0m 50s	the patch passed
+1 💚	shadedjars	6m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
-1 ❌	unit	256m 7s	hbase-server in the patch failed.
		281m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 76a21bda4a8a 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/testReport/
Max. process+thread count	5222 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… Tiering

Apache-HBase · 2024-04-10T13:07:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	2m 57s	HBASE-28463 passed
+1 💚	compile	2m 28s	HBASE-28463 passed
+1 💚	checkstyle	0m 36s	HBASE-28463 passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	2m 36s	the patch passed
+1 💚	javac	2m 36s	the patch passed
-0 ⚠️	checkstyle	0m 35s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 29s	Patch does not cause any errors with Hadoop 3.3.6.
-1 ❌	spotless	0m 46s	patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	2m 21s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		32m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 2960b2c85a47 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-10T16:59:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	2m 49s	HBASE-28463 passed
+1 💚	compile	0m 40s	HBASE-28463 passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	5m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
-1 ❌	unit	240m 1s	hbase-server in the patch failed.
		263m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4495b4a2ae53 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/
Max. process+thread count	5404 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-10T18:53:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	5m 1s	HBASE-28463 passed
+1 💚	compile	1m 11s	HBASE-28463 passed
+1 💚	shadedjars	7m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 30s	the patch passed
+1 💚	compile	1m 22s	the patch passed
+1 💚	javac	1m 22s	the patch passed
+1 💚	shadedjars	8m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	342m 36s	hbase-server in the patch failed.
		377m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9b869afe148c 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/testReport/
Max. process+thread count	4415 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-10T19:30:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	3m 53s	HBASE-28463 passed
+1 💚	compile	2m 54s	HBASE-28463 passed
+1 💚	checkstyle	0m 43s	HBASE-28463 passed
+1 💚	spotless	0m 52s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 50s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	compile	2m 56s	the patch passed
-0 ⚠️	javac	2m 56s	hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)
+1 💚	checkstyle	0m 44s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	6m 3s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	1m 2s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		35m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 61647e87054d 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-10T23:15:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	2m 49s	HBASE-28463 passed
+1 💚	compile	0m 39s	HBASE-28463 passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	5m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	237m 18s	hbase-server in the patch passed.
		260m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3b44d7b373c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/
Max. process+thread count	5986 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-10T23:45:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	4m 20s	HBASE-28463 passed
+1 💚	compile	1m 17s	HBASE-28463 passed
+1 💚	shadedjars	7m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	7m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	258m 30s	hbase-server in the patch passed.
		291m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fe87538c4481 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/testReport/
Max. process+thread count	4494 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

LGTM, overall, just posted some minor nits. Please address it and I'll merge it to the feature branch.

wchevreuil · 2024-04-11T09:08:14Z

hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java

+
+  private static void checkDateTieredCompactionForTimeRangeDataTiering(final Configuration conf)
+    throws IOException {
+    final String DATE_TIERED_STORE_ENGINE =


nit: make this a public constant somewhere in the date tiered compaction code, then import static here.

wchevreuil · 2024-04-11T09:13:31Z

hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java

+        if (!DATE_TIERED_STORE_ENGINE.equals(conf.get(StoreEngine.STORE_ENGINE_CLASS_KEY))) {
+          throw new IOException(errorMessage);
+        }


Nit: We should throw IllegalArgumentException, since this is rather a config error.

Apache-HBase · 2024-04-11T13:23:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	3m 17s	HBASE-28463 passed
+1 💚	compile	3m 0s	HBASE-28463 passed
+1 💚	checkstyle	0m 37s	HBASE-28463 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 34s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 51s	the patch passed
+1 💚	compile	2m 28s	the patch passed
+1 💚	javac	2m 28s	the patch passed
+1 💚	checkstyle	0m 36s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 44s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 48s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		32m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux c7e52c42d5c4 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	82 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-11T18:58:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	4m 34s	HBASE-28463 passed
+1 💚	compile	1m 8s	HBASE-28463 passed
+1 💚	shadedjars	6m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	6m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
-1 ❌	unit	335m 1s	hbase-server in the patch failed.
		367m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7734fb3ad69b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/
Max. process+thread count	4538 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-04-11T19:07:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-28463 Compile Tests _
+1 💚	mvninstall	3m 56s	HBASE-28463 passed
+1 💚	compile	0m 52s	HBASE-28463 passed
+1 💚	shadedjars	6m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	HBASE-28463 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
-1 ❌	unit	347m 14s	hbase-server in the patch failed.
		376m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5809
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bf07a665f134 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-28463 / `a9d3170`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/testReport/
Max. process+thread count	4437 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5809/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I67f611e828c457f00df98fb58bcd1fd9b08f57da

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89

…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89

…into cdh_main HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]> Change-Id: I30772e5e4ea0e91f862327616a108bd1033fee89

HBASE-28465 Implementation of framework for time-based priority bucke…

a9d3170

…t-cache (apache#5793) Signed-off-by: Wellington Chevreuil <[email protected]>

Implemented enforcement for Date Tiered Compaction in Time Range Data…

0dedee4

… Tiering

vinayakphegde force-pushed the HBASE-28505 branch from f4873ed to 0dedee4 Compare April 10, 2024 12:28

removed spotless errors

4064ff0

wchevreuil approved these changes Apr 11, 2024

View reviewed changes

enhanced the code

cd11d86

wchevreuil force-pushed the HBASE-28463 branch from a9d3170 to fe285bc Compare April 12, 2024 09:01

wchevreuil merged commit b7bb8b9 into apache:HBASE-28463 Apr 12, 2024

wchevreuil pushed a commit that referenced this pull request Apr 22, 2024

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

c1ea652

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Apr 25, 2024

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

9572f7d

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request May 20, 2024

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

99c412f

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

vinayakphegde added a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

8bf4d0e

…or Time Range Data Tiering (apache#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request May 21, 2024

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

6ff8b06

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Jun 24, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

db2e23f

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Jul 10, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

3e3064c

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Jul 11, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

025f685

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Aug 5, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

7525682

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Sep 1, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

2974949

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

wchevreuil pushed a commit that referenced this pull request Sep 1, 2025

HBASE-28505 Implement enforcement to require Date Tiered Compaction f…

36cf624

…or Time Range Data Tiering (#5809) Signed-off-by: Wellington Chevreuil <[email protected]>

HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering #5809

HBASE-28505 Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering #5809

Uh oh!

Conversation

vinayakphegde commented Apr 9, 2024

Uh oh!

Apache-HBase commented Apr 9, 2024

Uh oh!

Apache-HBase commented Apr 9, 2024

Uh oh!

Apache-HBase commented Apr 9, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

Apache-HBase commented Apr 10, 2024

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

wchevreuil Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

wchevreuil Apr 11, 2024

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 11, 2024

Uh oh!

Apache-HBase commented Apr 11, 2024

Uh oh!

Apache-HBase commented Apr 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants