HBASE-18999 Shell support for multiple columns for DML commands #5585

NihalJain · 2023-12-16T15:00:56Z

No description provided.

NihalJain · 2023-12-16T15:03:24Z

Draft PR with changes from the last submitted patch in HBASE-18999. I have run hbase build with this change along with the shell test cases.

Pending:

Will do a self review and see if code/docs can be improved. For example I see some cryptic code in put.rb /append.rb
And also test out using a shell instance.

CC: @Apache9

hbase-shell/src/main/ruby/shell/commands/append.rb

hbase-shell/src/main/ruby/shell/commands/put.rb

Apache-HBase · 2023-12-16T15:21:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 5s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 52s	the patch passed
-0 ⚠️	rubocop	0m 19s	The patch generated 200 new + 395 unchanged - 12 fixed = 595 total (was 407)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		11m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 0cb042f9f2ce 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7c3f8c`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-16T15:26:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 44s	hbase-shell in the patch passed.
		15m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	javac javadoc unit
uname	Linux 1a1668a49eb5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7c3f8c`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/testReport/
Max. process+thread count	1585 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-12-16T15:26:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 36s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 20s	the patch passed
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 53s	hbase-shell in the patch passed.
		16m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	javac javadoc unit
uname	Linux cc1bc9bd7a55 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b7c3f8c`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/testReport/
Max. process+thread count	1525 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-01-06T17:50:20Z

Pushed local changes, still not ready, will do a little more self review and testing. Will take up later.

Apache-HBase · 2024-01-06T18:05:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
-0 ⚠️	rubocop	0m 20s	The patch generated 201 new + 396 unchanged - 15 fixed = 597 total (was 411)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		9m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	dupname asflicense javac spotless rubocop
uname	Linux 95c7088b2ea7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4aeabdc`
Default Java	Eclipse Adoptium-11.0.17+8
rubocop	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions	git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-06T18:10:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 58s	master passed
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
-1 ❌	unit	6m 59s	hbase-shell in the patch failed.
		14m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	javac javadoc unit
uname	Linux 1c62e1db533a 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4aeabdc`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/testReport/
Max. process+thread count	2029 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-06T18:11:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 37s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	javadoc	0m 8s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 45s	hbase-shell in the patch failed.
		15m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5585
Optional Tests	javac javadoc unit
uname	Linux b2ef01abe68e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4aeabdc`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/testReport/
Max. process+thread count	1987 (vs. ulimit of 30000)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5585/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2025-08-31T12:15:51Z

Any updates here? @NihalJain

Plan to make the final 3.0.0-beta-2 release, so I'm cleaning up the pending issues for 3.0.0-beta-2.

NihalJain · 2025-08-31T14:21:41Z

ah sure, let me try start this off again.

Apache9 · 2025-09-13T12:15:36Z

@NihalJain Do you still have time to finish this before we cut 3.0.0-beta-2?

There are only 4 issues left for now.

Apache9 · 2025-10-07T12:23:56Z

Ping @NihalJain

NihalJain marked this pull request as draft December 16, 2023 15:01

NihalJain commented Dec 16, 2023

View reviewed changes

hbase-shell/src/main/ruby/shell/commands/append.rb Show resolved Hide resolved

NihalJain commented Dec 16, 2023

View reviewed changes

hbase-shell/src/main/ruby/shell/commands/put.rb Show resolved Hide resolved

NihalJain added 2 commits December 20, 2023 22:52

HBASE-18999 Shell support for multiple columns for DML commands

92234c6

Add more docs, refactor code

de9c3eb

NihalJain force-pushed the HBASE-18999 branch from 08829d7 to de9c3eb Compare January 6, 2024 17:48

HBASE-18999 Shell support for multiple columns for DML commands #5585

Are you sure you want to change the base?

HBASE-18999 Shell support for multiple columns for DML commands #5585

Conversation

NihalJain commented Dec 16, 2023

Uh oh!

NihalJain commented Dec 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Dec 16, 2023

Uh oh!

Apache-HBase commented Dec 16, 2023

Uh oh!

Apache-HBase commented Dec 16, 2023

Uh oh!

NihalJain commented Jan 6, 2024

Uh oh!

Apache-HBase commented Jan 6, 2024

Uh oh!

Apache-HBase commented Jan 6, 2024

Uh oh!

Apache-HBase commented Jan 6, 2024

Uh oh!

Apache9 commented Aug 31, 2025

Uh oh!

NihalJain commented Aug 31, 2025

Uh oh!

Apache9 commented Sep 13, 2025

Uh oh!

Apache9 commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NihalJain commented Dec 16, 2023 •

edited

Loading