HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS #5558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to priority ADMIN_QOS
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…to priority ADMIN_QOS
Kerasone
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Dec 7, 2023
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
Show resolved
Hide resolved
…to priority ADMIN_QOS
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@wchevreuil done |
Contributor
Author
|
hello,test has been done,can you give me some suggestions?thank you very much
…---- Replied Message ----
| From | Wellington Ramos ***@***.***> |
| Date | 12/07/2023 22:27 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/hbase] HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (PR #5558) |
@wchevreuil commented on this pull request.
On hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
Can we add related checks in TestRSQosFunction.testAnnotations?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
chrajeshbabu
approved these changes
Feb 16, 2024
Contributor
chrajeshbabu
left a comment
chrajeshbabu
left a comment
There was a problem hiding this comment.
+1 lgtm. @wchevreuil will commit it if no objections.
chrajeshbabu
pushed a commit
that referenced
this pull request
Feb 19, 2024
…to priority ADMIN_QOS (#5558) HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (#5558) Co-authored-by: selina.yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updateConfiguration operation called by admin should be considered a higher priority operation and given to the priority queue, but is currently considered to have the same priority as read and write requests. If the handle is occupied, the configuration cannot be updated. In fact, in our scenario, some abnormal phoenix sql is killed by controlling the amount of data that scan can filter with dynamic parameters. Abnormal sql often results in a full handle. In this case, the configuration cannot be dynamically modified to implement emergency traffic limiting.