Skip to content

HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 4 commits into from
Dec 4, 2023
Merged

HBASE-28226 Add logic to check for RegionStateNode null pointer in FlushRegionProcedure #5548

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4568fc
Add logic to check for null pointer; if a null pointer is detected, t…
Nov 29, 2023
95751aa
Format the code
Nov 29, 2023
10ee5b6
Format the code
Nov 30, 2023
ed7addd
split line
Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...e-server/src/main/java/org/apache/hadoop/hbase/master/procedure/FlushRegionProcedure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ protected Procedure<MasterProcedureEnv>[] execute(MasterProcedureEnv env)

RegionStates regionStates = env.getAssignmentManager().getRegionStates();
RegionStateNode regionNode = regionStates.getRegionStateNode(region);
if (regionNode == null) {
LOG.debug(
"Region {} is not in region states, it is very likely that it has been cleared by other procedures such as merge or split, so skip {}. See HBASE-28226",
Copy link
Contributor

@Apache9 Apache9 Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is too long, please split it so we can avoid the checkstyle warning? The maximum length for HBase is 100.

Copy link
Contributor Author

@hiping-tech hiping-tech Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder, I have split it into two lines.

region, this);
return null;
}
regionNode.lock();
try {
if (!regionNode.isInState(State.OPEN) || regionNode.isInTransition()) {
Expand Down