-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28220 Split the queueCallTime, processCallTime and totalCallTime according to queue type when using RWQueueRpcExecutor #5540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: branch-2.5
Are you sure you want to change the base?
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Please run spotless:apply to fix the checkstyle problem and try to fix the broken UT first ? Thanks. |
…e according to queue type when using RWQueueRpcExecutor
e9d51c2 to
cefeafa
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Thank you for your attention and suggestion! I have fixed the checkstyle problem and passed all the unit tests. Thank you for your support! |
|
Please open a PR against master first? In HBase usually we will apply patches to master branch first, and then backport to other branches. Thanks. |
Got it, I will open a PR against the master branch soon. Thank you for your guidance. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
When using RWQueueRpcExecutor, in order to monitor the running status of the read and write queues separately, it is necessary to monitor the queueTime and processingTime of the request according to the queue type. In this way, the queue's queueCallTime, processCallTime and totalCallTime metrics are split according to the read and write queue types. So Add the following metrics:
These metrics are important references for subsequent modification of parameters hbase.ipc.server.callqueue.read.ratio and hbase.ipc.server.callqueue.scan.ratio.