Skip to content

HBASE-28186 Rebase CacheAwareBalance related commits into master branch #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taklwu merged 2 commits into from
Nov 21, 2023
Merged

HBASE-28186 Rebase CacheAwareBalance related commits into master branch #5527

taklwu merged 2 commits into from
Nov 21, 2023

Conversation

@wchevreuil
Copy link
Contributor

@wchevreuil wchevreuil commented Nov 17, 2023

No description provided.

@wchevreuil wchevreuil requested a review from taklwu November 17, 2023 10:59
@Apache-HBase
Copy link

Apache-HBase commented Nov 17, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 3m 25s master passed
+1 💚 checkstyle 0m 59s master passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 2m 25s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 40s the patch passed
+1 💚 compile 3m 23s the patch passed
-0 ⚠️ javac 0m 21s hbase-balancer generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-0 ⚠️ checkstyle 0m 10s hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 9m 22s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 48s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
37m 39s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5527
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 74bd80e5105e 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9e74cc0
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-balancer.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
Max. process+thread count 77 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 17, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 30s master passed
+1 💚 compile 1m 2s master passed
+1 💚 shadedjars 5m 9s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 18s the patch passed
+1 💚 compile 1m 4s the patch passed
+1 💚 javac 1m 4s the patch passed
+1 💚 shadedjars 5m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s the patch passed
_ Other Tests _
+1 💚 unit 2m 16s hbase-common in the patch passed.
+1 💚 unit 9m 6s hbase-balancer in the patch passed.
-1 ❌ unit 12m 42s hbase-server in the patch failed.
45m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5527
Optional Tests javac javadoc unit shadedjars compile
uname Linux 298e337e01b1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9e74cc0
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/testReport/
Max. process+thread count 1636 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 17, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 32s master passed
+1 💚 compile 1m 40s master passed
+1 💚 shadedjars 6m 26s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 43s the patch passed
+1 💚 compile 1m 28s the patch passed
+1 💚 javac 1m 28s the patch passed
+1 💚 shadedjars 5m 34s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 55s the patch passed
_ Other Tests _
+1 💚 unit 2m 32s hbase-common in the patch passed.
+1 💚 unit 11m 59s hbase-balancer in the patch passed.
-1 ❌ unit 18m 5s hbase-server in the patch failed.
60m 54s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5527
Optional Tests javac javadoc unit shadedjars compile
uname Linux 41ce3a7b972a 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9e74cc0
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/testReport/
Max. process+thread count 1732 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
adding extra check for null/empty string in getFileSize
1fe6be2 
Change-Id: I793c8f762116d70e74d186823612c35455357a1e
@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 2m 42s master passed
+1 💚 compile 3m 19s master passed
+1 💚 checkstyle 1m 0s master passed
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
+1 💚 spotbugs 2m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 3m 19s the patch passed
-0 ⚠️ javac 0m 20s hbase-balancer generated 2 new + 14 unchanged - 0 fixed = 16 total (was 14)
-0 ⚠️ checkstyle 0m 10s hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 9m 18s Patch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
+1 💚 spotbugs 2m 46s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
38m 0s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5527
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux c182c4d2a9ea 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9631af7
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-balancer.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 22s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 2m 44s master passed
+1 💚 compile 1m 24s master passed
+1 💚 shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 1m 23s the patch passed
+1 💚 javac 1m 23s the patch passed
+1 💚 shadedjars 4m 55s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 54s the patch passed
_ Other Tests _
+1 💚 unit 2m 19s hbase-common in the patch passed.
+1 💚 unit 11m 22s hbase-balancer in the patch passed.
+1 💚 unit 230m 10s hbase-server in the patch passed.
272m 51s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5527
Optional Tests javac javadoc unit shadedjars compile
uname Linux da04506df1ff 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9631af7
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/testReport/
Max. process+thread count 4849 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Nov 20, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 19s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 28s master passed
+1 💚 compile 1m 11s master passed
+1 💚 shadedjars 4m 43s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 48s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 26s the patch passed
+1 💚 compile 1m 10s the patch passed
+1 💚 javac 1m 10s the patch passed
+1 💚 shadedjars 4m 43s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 50s the patch passed
_ Other Tests _
+1 💚 unit 1m 56s hbase-common in the patch passed.
+1 💚 unit 9m 4s hbase-balancer in the patch passed.
+1 💚 unit 273m 52s hbase-server in the patch passed.
312m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5527
Optional Tests javac javadoc unit shadedjars compile
uname Linux ed8ea1328999 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9631af7
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/testReport/
Max. process+thread count 4607 (vs. ulimit of 30000)
modules C: hbase-common hbase-balancer hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5527/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu taklwu merged commit e799ee0 into master Nov 21, 2023
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Nov 22, 2023
@wchevreuil @ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
5bac2d7 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>
ragarkar added a commit to ragarkar/hbase that referenced this pull request Nov 27, 2023
@ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
8f5533f 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil @ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
605014a 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil @ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
d991af1 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil @ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
bd6a7fe 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
ragarkar pushed a commit to ragarkar/hbase that referenced this pull request Nov 29, 2023
@wchevreuil @ragarkar
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)
8d4eb9d 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
wchevreuil added a commit that referenced this pull request Nov 30, 2023
@wchevreuil
HBASE-27999 Implement cache prefetch aware load balancer (#5527)
e167714 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
wchevreuil added a commit that referenced this pull request Nov 30, 2023
@wchevreuil
HBASE-27999 Implement cache prefetch aware load balancer (#5527)
b74429a 
this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@wchevreuil @ragarkar
CDPD-64481: Backport HBASE-27997, HBASE-27998 and HBASE-27999
83f5933 
HBASE-27999 Implement cache prefetch aware load balancer (apache#5527)

this commit is part of the rebase of HBASE-28186

Signed-off-by: Wellington Chevreuil <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Co-authored-by: Rahul Agarkar <[email protected]>

(cherry picked from commit e799ee0)
Change-Id: I0dcd432d869159fc8e068ecb0ee18aa8f86fa278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taklwu taklwu taklwu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wchevreuil @Apache-HBase @taklwu @ragarkar