-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28050 RSProcedureDispatcher to fail-fast for krb auth failures #5391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
3a5bc01
a61c49f
4a79223
8549505
a8ba2ee
420fcb6
8b59b13
6fbfe4d
fbea61e
a8626fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.ipc; | ||
|
|
||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| /** | ||
| * Constants to be used by RPC connection based utilities. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public final class RpcConnectionConstants { | ||
|
|
||
| private RpcConnectionConstants() { | ||
| } | ||
|
|
||
| public static final String RELOGIN_IS_IN_PROGRESS = | ||
| "Can not send request because relogin is in progress."; | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,11 +22,13 @@ | |
| import java.util.List; | ||
| import java.util.Set; | ||
| import java.util.concurrent.TimeUnit; | ||
| import javax.security.sasl.SaslException; | ||
| import org.apache.hadoop.hbase.CallQueueTooBigException; | ||
| import org.apache.hadoop.hbase.DoNotRetryIOException; | ||
| import org.apache.hadoop.hbase.ServerName; | ||
| import org.apache.hadoop.hbase.client.AsyncRegionServerAdmin; | ||
| import org.apache.hadoop.hbase.client.RegionInfo; | ||
| import org.apache.hadoop.hbase.ipc.RpcConnectionConstants; | ||
| import org.apache.hadoop.hbase.ipc.ServerNotRunningYetException; | ||
| import org.apache.hadoop.hbase.master.MasterServices; | ||
| import org.apache.hadoop.hbase.master.ServerListener; | ||
|
|
@@ -287,17 +289,7 @@ private boolean scheduleForRetry(IOException e) { | |
| numberOfAttemptsSoFar); | ||
| return false; | ||
| } | ||
| // This exception is thrown in the rpc framework, where we can make sure that the call has not | ||
| // been executed yet, so it is safe to mark it as fail. Especially for open a region, we'd | ||
| // better choose another region server. | ||
| // Notice that, it is safe to quit only if this is the first time we send request to region | ||
| // server. Maybe the region server has accepted our request the first time, and then there is | ||
| // a network error which prevents we receive the response, and the second time we hit a | ||
| // CallQueueTooBigException, obviously it is not safe to quit here, otherwise it may lead to a | ||
| // double assign... | ||
| if (e instanceof CallQueueTooBigException && numberOfAttemptsSoFar == 0) { | ||
| LOG.warn("request to {} failed due to {}, try={}, this usually because" | ||
| + " server is overloaded, give up", serverName, e.toString(), numberOfAttemptsSoFar); | ||
| if (numberOfAttemptsSoFar == 0 && unableToConnectToServer(e)) { | ||
| return false; | ||
| } | ||
| // Always retry for other exception types if the region server is not dead yet. | ||
|
|
@@ -330,6 +322,73 @@ private boolean scheduleForRetry(IOException e) { | |
| return true; | ||
| } | ||
|
|
||
| private boolean unableToConnectToServer(IOException e) { | ||
| // This exception is thrown in the rpc framework, where we can make sure that the call has not | ||
| // been executed yet, so it is safe to mark it as fail. Especially for open a region, we'd | ||
| // better choose another region server. | ||
| // Notice that, it is safe to quit only if this is the first time we send request to region | ||
| // server. Maybe the region server has accepted our request the first time, and then there is | ||
| // a network error which prevents we receive the response, and the second time we hit a | ||
| // CallQueueTooBigException, obviously it is not safe to quit here, otherwise it may lead to a | ||
| // double assign... | ||
| if (e instanceof CallQueueTooBigException) { | ||
| LOG.warn("request to {} failed due to {}, try={}, this usually because" | ||
| + " server is overloaded, give up", serverName, e, numberOfAttemptsSoFar); | ||
| return true; | ||
| } | ||
| if (isSaslError(e)) { | ||
Apache9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| LOG.warn("{} is not reachable; give up after first attempt", serverName, e); | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private boolean isSaslError(IOException e) { | ||
| if ( | ||
| e instanceof SaslException || (e.getMessage() != null | ||
| && e.getMessage().contains(RpcConnectionConstants.RELOGIN_IS_IN_PROGRESS)) | ||
Apache9 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ) { | ||
| return true; | ||
| } | ||
| // check 4 level of cause | ||
|
||
| Throwable cause = e.getCause(); | ||
| if (cause == null) { | ||
| return false; | ||
| } | ||
| if (isSaslError(cause)) { | ||
| return true; | ||
| } | ||
| cause = cause.getCause(); | ||
| if (cause == null) { | ||
| return false; | ||
| } | ||
| if (isSaslError(cause)) { | ||
| return true; | ||
| } | ||
| cause = cause.getCause(); | ||
| if (cause == null) { | ||
| return false; | ||
| } | ||
| if (isSaslError(cause)) { | ||
| return true; | ||
| } | ||
| cause = cause.getCause(); | ||
| if (cause == null) { | ||
| return false; | ||
| } | ||
| return isSaslError(cause); | ||
| } | ||
|
|
||
| private boolean isSaslError(Throwable cause) { | ||
|
||
| if (cause instanceof IOException) { | ||
| IOException unwrappedException = unwrapException((IOException) cause); | ||
| return unwrappedException instanceof SaslException | ||
| || (unwrappedException.getMessage() != null && unwrappedException.getMessage() | ||
| .contains(RpcConnectionConstants.RELOGIN_IS_IN_PROGRESS)); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| private long getMaxWaitTime() { | ||
| if (this.maxWaitTime < 0) { | ||
| // This is the max attempts, not retries, so it should be at least 1. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better move this block of comments to the if condition in the caller method? I mean the section start from 'Notice that, it is safe blabla'. The numberOfAttemptsSoFar == 0 test is there.