Skip to content

HBASE-27885 expose metaCacheHits in MetricsConnection #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frostruan wants to merge 4 commits into from
Closed

HBASE-27885 expose metaCacheHits in MetricsConnection #5253

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3d37b7
HBASE-27885 expose metaCacheHits in MetricsConnection
May 24, 2023
986f754
add a test case for getMetaCacheHits
May 25, 2023
2ea8ebd
improve test case
May 26, 2023
a825eb0
improve test case
May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,10 @@ public void incrMetaCacheHit() {
metaCacheHits.inc();
}

public long getMetaCacheHits() {
return metaCacheHits.getCount();
}

/** Increment the number of meta cache misses. */
public void incrMetaCacheMiss() {
metaCacheMisses.inc();
Expand Down
6 changes: 6 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMetaCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ public void testPreserveMetaCacheOnException() throws Exception {

Exception exp;
boolean success;
long initialMetaCacheHits = metrics.getMetaCacheHits();
for (int i = 0; i < 50; i++) {
exp = null;
success = false;
Expand All @@ -253,6 +254,11 @@ public void testPreserveMetaCacheOnException() throws Exception {
table.increment(increment);
table.delete(delete);
table.mutateRow(mutations);
// The value of the metaCacheHits counter is incremented by 6 in each round of the loop,
// for 0th iteration there will be 5 hits + 1 cache miss.
assertEquals(initialMetaCacheHits + 6 * i + 5, metrics.getMetaCacheHits());
// We will get a cache miss only on the first request, so the value will always be 1.
assertEquals(1, metrics.getMetaCacheMisses());
Copy link
Contributor

@NihalJain NihalJain May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init getMetaCacheMisses too before asserting similar to initialMetaCacheHits? Thanks for the quick review addressal :)

Copy link
Contributor Author

@frostruan frostruan May 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind taking a look on the newest commit and seeing if this is what you were expecting in your free time ? REALLY thanks for your patience ! :)

} catch (IOException ex) {
// Only keep track of the last exception that updated the meta cache
if (ClientExceptionsUtil.isMetaClearingException(ex) || success) {
Expand Down