Skip to content

HBASE-27851 Fix TestListTablesByState which is silently failing due to a surefire bug #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 1 commit into from
May 11, 2023
Merged

HBASE-27851 Fix TestListTablesByState which is silently failing due to a surefire bug #5227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestListTablesByState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,15 @@
import org.apache.hadoop.hbase.HBaseTestingUtil;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.client.Admin;
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
import org.apache.hadoop.hbase.testclassification.MasterTests;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.util.Bytes;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Test;
Expand All @@ -40,7 +43,12 @@ public class TestListTablesByState {

private static HBaseTestingUtil UTIL;
private static Admin ADMIN;
private final static int SLAVES = 1;
private static final int SLAVES = 1;
private static final byte[] COLUMN = Bytes.toBytes("cf");
private static final TableName TABLE = TableName.valueOf("test");
private static final TableDescriptor TABLE_DESC = TableDescriptorBuilder.newBuilder(TABLE)
.setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(COLUMN).setMaxVersions(3).build())
.build();

@BeforeClass
public static void setUpBeforeClass() throws Exception {
Expand All @@ -49,26 +57,33 @@ public static void setUpBeforeClass() throws Exception {
ADMIN = UTIL.getAdmin();
}

@Before
public void before() throws Exception {
if (ADMIN.tableExists(TABLE)) {
if (ADMIN.isTableEnabled(TABLE)) {
ADMIN.disableTable(TABLE);
}

ADMIN.deleteTable(TABLE);
}
}

@Test
public void testListTableNamesByState() throws Exception {
TableName testTableName = TableName.valueOf("test");
TableDescriptor testTableDesc = TableDescriptorBuilder.newBuilder(testTableName).build();
ADMIN.createTable(testTableDesc);
ADMIN.disableTable(testTableName);
Assert.assertEquals(ADMIN.listTableNamesByState(false).get(0), testTableName);
ADMIN.enableTable(testTableName);
Assert.assertEquals(ADMIN.listTableNamesByState(true).get(0), testTableName);
ADMIN.createTable(TABLE_DESC);
ADMIN.disableTable(TABLE);
Assert.assertEquals(ADMIN.listTableNamesByState(false).get(0), TABLE);
ADMIN.enableTable(TABLE);
Assert.assertEquals(ADMIN.listTableNamesByState(true).get(0), TABLE);
}

@Test
public void testListTableDescriptorByState() throws Exception {
TableName testTableName = TableName.valueOf("test");
TableDescriptor testTableDesc = TableDescriptorBuilder.newBuilder(testTableName).build();
ADMIN.createTable(testTableDesc);
ADMIN.disableTable(testTableName);
Assert.assertEquals(ADMIN.listTableDescriptorsByState(false).get(0), testTableDesc);
ADMIN.enableTable(testTableName);
Assert.assertEquals(ADMIN.listTableDescriptorsByState(true).get(0), testTableDesc);
ADMIN.createTable(TABLE_DESC);
ADMIN.disableTable(TABLE);
Assert.assertEquals(ADMIN.listTableDescriptorsByState(false).get(0).getTableName(), TABLE);
ADMIN.enableTable(TABLE);
Assert.assertEquals(ADMIN.listTableDescriptorsByState(true).get(0).getTableName(), TABLE);
}

@AfterClass
Expand Down