HBASE-27788 Skip family comparing when compare cells inner the store #5171
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
| import org.apache.yetus.audience.InterfaceStability; | ||
|
|
||
| /** | ||
| * Compare two HBase cells inner store, skip compare family for better performance. Important!!! we | ||
| * should not make fake cell with fake family which length greater than zero inner store, otherwise | ||
| * this optimization cannot be used. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Evolving | ||
| public class InnerStoreCellComparator extends CellComparatorImpl { | ||
|
|
||
| private static final long serialVersionUID = 8186411895799094989L; | ||
|
|
||
| public static final InnerStoreCellComparator INNER_STORE_COMPARATOR = | ||
| new InnerStoreCellComparator(); | ||
|
|
||
| @Override | ||
| protected int compareFamilies(Cell left, int leftFamilyLength, Cell right, | ||
| int rightFamilyLength) { | ||
| return leftFamilyLength - rightFamilyLength; | ||
| } | ||
|
|
||
| @Override | ||
| protected int compareFamilies(KeyValue left, int leftFamilyPosition, int leftFamilyLength, | ||
| KeyValue right, int rightFamilyPosition, int rightFamilyLength) { | ||
| return leftFamilyLength - rightFamilyLength; | ||
| } | ||
|
|
||
| @Override | ||
| protected int compareFamilies(ByteBufferKeyValue left, int leftFamilyPosition, | ||
| int leftFamilyLength, ByteBufferKeyValue right, int rightFamilyPosition, | ||
| int rightFamilyLength) { | ||
| return leftFamilyLength - rightFamilyLength; | ||
| } | ||
|
|
||
| @Override | ||
| protected int compareFamilies(KeyValue left, int leftFamilyPosition, int leftFamilyLength, | ||
| ByteBufferKeyValue right, int rightFamilyPosition, int rightFamilyLength) { | ||
| return leftFamilyLength - rightFamilyLength; | ||
| } | ||
|
|
||
| /** | ||
| * Utility method that makes a guess at comparator to use based off passed tableName. Use in | ||
| * extreme when no comparator specified. | ||
| * @return CellComparator to use going off the {@code tableName} passed. | ||
| */ | ||
| public static CellComparator getInnerStoreCellComparator(Configuration conf, | ||
| TableName tableName) { | ||
| return getInnerStoreCellComparator(conf, tableName.toBytes()); | ||
| } | ||
|
|
||
| /** | ||
| * Utility method that makes a guess at comparator to use based off passed tableName. Use in | ||
| * extreme when no comparator specified. | ||
| * @return CellComparator to use going off the {@code tableName} passed. | ||
| */ | ||
| public static CellComparator getInnerStoreCellComparator(byte[] tableName) { | ||
| return getInnerStoreCellComparator(null, tableName); | ||
| } | ||
|
|
||
| public static CellComparator getInnerStoreCellComparator(Configuration conf, byte[] tableName) { | ||
| if ( | ||
| conf != null && conf.getBoolean(HConstants.USE_META_CELL_COMPARATOR, | ||
| HConstants.DEFAULT_USE_META_CELL_COMPARATOR) | ||
| ) { | ||
| return MetaCellComparator.META_COMPARATOR; | ||
| } | ||
| return Bytes.equals(tableName, TableName.META_TABLE_NAME.toBytes()) | ||
| ? MetaCellComparator.META_COMPARATOR | ||
| : InnerStoreCellComparator.INNER_STORE_COMPARATOR; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this judgement in upper layer so we do not need to move USE_META_CELL_COMPARATOR to HConstants? It is just for internal use, we'd better not put it into an IA.Public class...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try.