Skip to content

HBASE-27473 Fix spotbugs warnings in hbase-rest Client.getResponseBody #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 1 commit into from
Nov 10, 2022
Merged

HBASE-27473 Fix spotbugs warnings in hbase-rest Client.getResponseBody #4867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import java.io.BufferedInputStream;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -65,6 +64,9 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.apache.hbase.thirdparty.com.google.common.io.ByteStreams;
import org.apache.hbase.thirdparty.com.google.common.io.Closeables;

/**
* A wrapper around HttpClient which provides some useful function and semantics for interacting
* with the REST gateway.
Expand Down Expand Up @@ -492,29 +494,30 @@ public Response get(String path, Header[] headers) throws IOException {
* @return The response body, null if body is empty
* @throws IOException If an I/O (transport) problem occurs while obtaining the response body.
*/
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value = "NP_LOAD_OF_KNOWN_NULL_VALUE",
justification = "null is possible return value")
public static byte[] getResponseBody(HttpResponse resp) throws IOException {
if (resp.getEntity() == null) return null;
try (InputStream instream = resp.getEntity().getContent()) {
if (instream != null) {
long contentLength = resp.getEntity().getContentLength();
if (contentLength > Integer.MAX_VALUE) {
// guard integer cast from overflow
throw new IOException("Content too large to be buffered: " + contentLength + " bytes");
}
ByteArrayOutputStream outstream =
new ByteArrayOutputStream(contentLength > 0 ? (int) contentLength : 4 * 1024);
byte[] buffer = new byte[4096];
int len;
while ((len = instream.read(buffer)) > 0) {
outstream.write(buffer, 0, len);
}
outstream.close();
return outstream.toByteArray();
}
if (resp.getEntity() == null) {
return null;
}
InputStream instream = resp.getEntity().getContent();
if (instream == null) {
return null;
}
try {
long contentLength = resp.getEntity().getContentLength();
if (contentLength > Integer.MAX_VALUE) {
// guard integer cast from overflow
throw new IOException("Content too large to be buffered: " + contentLength + " bytes");
}
if (contentLength > 0) {
byte[] content = new byte[(int) contentLength];
ByteStreams.readFully(instream, content);
return content;
} else {
return ByteStreams.toByteArray(instream);
}
} finally {
Closeables.closeQuietly(instream);
}
}

/**
Expand Down