Skip to content

HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abhradeepkundu wants to merge 4 commits into from
Closed

HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory #4772

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f810ce
Rectifying the option for columnfamily as mandatory
Aug 24, 2022
0ae0117
Adding the comment in a string so that we can resuse it
Aug 26, 2022
202435d
spotless check applied
Aug 26, 2022
557be62
Rectified the options correctly
Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ...org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ public class StoreFileListFilePrettyPrinter extends Configured implements Tool {
private final String regionOption = "r";
private final String tableNameOption = "t";

private final String helpMsg = "sft [--f=</path/to/tracker/file> | --t=<namespace:"
+ "tablename|tablename> --r=<regionname> --cf=<columnfamily> ]";

private String namespace;
private String regionName;
private String columnFamily;
Expand Down Expand Up @@ -96,9 +99,7 @@ private void init() {
public boolean parseOptions(String[] args) throws ParseException, IOException {
HelpFormatter formatter = new HelpFormatter();
if (args.length == 0) {
formatter
.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename>"
+ " --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
formatter.printHelp(helpMsg, options, true);
return false;
}

Expand All @@ -111,22 +112,19 @@ public boolean parseOptions(String[] args) throws ParseException, IOException {
regionName = cmd.getOptionValue(regionOption);
if (StringUtils.isEmpty(regionName)) {
err.println("Region name is not specified.");
formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|"
+ "tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
formatter.printHelp(helpMsg, options, true);
System.exit(1);
}
columnFamily = cmd.getOptionValue(columnFamilyOption);
if (StringUtils.isEmpty(columnFamily)) {
err.println("Column family is not specified.");
formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|"
+ "tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
formatter.printHelp(helpMsg, options, true);
System.exit(1);
}
String tableNameWtihNS = cmd.getOptionValue(tableNameOption);
if (StringUtils.isEmpty(tableNameWtihNS)) {
err.println("Table name is not specified.");
formatter.printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|"
+ "tablename> --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
formatter.printHelp(helpMsg, options, true);
System.exit(1);
}
TableName tn = TableName.valueOf(tableNameWtihNS);
Expand Down