Skip to content

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 2 commits into from
Aug 4, 2022
Merged

HBASE-27269 The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect #4678

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8604cd
HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…
2005hithlj Aug 4, 2022
5a468c5
HBASE-27269 The implementation of TestReplicationStatus.waitOnMetrics…
2005hithlj Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ private List<ReplicationLoadSource> waitOnMetricsReport(int greaterThan, ServerN
metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
while (list.size() <= greaterThan) {
Threads.sleep(1000);
list = metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList();
Copy link
Contributor

@Apache9 Apache9 Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still incorrect...

We need to call hbaseAdmin.getClusterMetrics every time when checking...

And here we'd better use the waitFor method to limit the max wait time?

Copy link
Contributor Author

@2005hithlj 2005hithlj Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. @Apache9
Sorry, I made an obvious mistake.

}
return list;
}
Expand Down