-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-22809 Allow creating table in group when rs group contains no l… #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
Outdated
Show resolved
Hide resolved
| "No servers in the rsgroup " + group.getName() + " for namespace " + ns.getName()); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought these method can be refacotred to 3 methods:
- getRSGroupForTable()
- getRSGroupForNamespace()
- checkRSGroup() : it will check RSGroup exists and not empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here is not that straight-forward. If we are modifying table, we do not need to check the group if the group config is not changed or we just removed the group config. So does namespace...
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (apache#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers (apache#464) Signed-off-by: Guanghao Zhang <[email protected]>
…ive servers