Skip to content

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Aug 7, 2019

…ive servers

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 205 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1 mvninstall 353 HBASE-22514 passed
+1 compile 57 HBASE-22514 passed
+1 checkstyle 90 HBASE-22514 passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 41 HBASE-22514 passed
0 spotbugs 298 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 296 HBASE-22514 passed
_ Patch Compile Tests _
+1 mvninstall 329 the patch passed
+1 compile 64 the patch passed
+1 javac 64 the patch passed
+1 checkstyle 88 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 318 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1037 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 304 the patch passed
_ Other Tests _
-1 unit 13143 hbase-server in the patch failed.
+1 asflicense 27 The patch does not generate ASF License warnings.
17101
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/artifact/out/Dockerfile
GITHUB PR #464
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5ff6f81b8859 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revision HBASE-22514 / 77e95bd
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/testReport/
Max. process+thread count 4436 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 requested a review from infraio August 8, 2019 01:31
"No servers in the rsgroup " + group.getName() + " for namespace " + ns.getName());
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these method can be refacotred to 3 methods:

  1. getRSGroupForTable()
  2. getRSGroupForNamespace()
  3. checkRSGroup() : it will check RSGroup exists and not empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is not that straight-forward. If we are modifying table, we do not need to check the group if the group config is not changed or we just removed the group config. So does namespace...

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1 mvninstall 376 HBASE-22514 passed
+1 compile 61 HBASE-22514 passed
+1 checkstyle 74 HBASE-22514 passed
+1 shadedjars 266 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 HBASE-22514 passed
0 spotbugs 259 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 256 HBASE-22514 passed
_ Patch Compile Tests _
+1 mvninstall 300 the patch passed
+1 compile 55 the patch passed
+1 javac 55 the patch passed
+1 checkstyle 75 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 266 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1002 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 259 the patch passed
_ Other Tests _
-1 unit 16114 hbase-server in the patch failed.
+1 asflicense 42 The patch does not generate ASF License warnings.
19647
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableAdminApi2
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/artifact/out/Dockerfile
GITHUB PR #464
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fd04d12ec33f 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revision HBASE-22514 / e4b1720
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/testReport/
Max. process+thread count 4596 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 163 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ HBASE-22514 Compile Tests _
+1 mvninstall 552 HBASE-22514 passed
+1 compile 80 HBASE-22514 passed
+1 checkstyle 105 HBASE-22514 passed
+1 shadedjars 385 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 51 HBASE-22514 passed
0 spotbugs 350 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 347 HBASE-22514 passed
_ Patch Compile Tests _
+1 mvninstall 413 the patch passed
+1 compile 67 the patch passed
+1 javac 67 the patch passed
+1 checkstyle 101 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 366 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1398 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 49 the patch passed
+1 findbugs 332 the patch passed
_ Other Tests _
-1 unit 15601 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
20583
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/artifact/out/Dockerfile
GITHUB PR #464
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f3107b79f42f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-464/out/precommit/personality/provided.sh
git revision HBASE-22514 / e4b1720
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/testReport/
Max. process+thread count 4384 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-464/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 595aa9d into apache:HBASE-22514 Aug 9, 2019
asfgit pushed a commit that referenced this pull request Aug 15, 2019
asfgit pushed a commit that referenced this pull request Aug 16, 2019
asfgit pushed a commit that referenced this pull request Aug 18, 2019
asfgit pushed a commit that referenced this pull request Aug 22, 2019
asfgit pushed a commit that referenced this pull request Aug 24, 2019
asfgit pushed a commit that referenced this pull request Aug 25, 2019
asfgit pushed a commit that referenced this pull request Aug 27, 2019
asfgit pushed a commit that referenced this pull request Sep 1, 2019
asfgit pushed a commit that referenced this pull request Sep 2, 2019
asfgit pushed a commit that referenced this pull request Sep 2, 2019
asfgit pushed a commit that referenced this pull request Sep 4, 2019
asfgit pushed a commit that referenced this pull request Sep 7, 2019
asfgit pushed a commit that referenced this pull request Sep 9, 2019
asfgit pushed a commit that referenced this pull request Sep 10, 2019
asfgit pushed a commit that referenced this pull request Sep 10, 2019
asfgit pushed a commit that referenced this pull request Sep 10, 2019
asfgit pushed a commit that referenced this pull request Sep 11, 2019
asfgit pushed a commit that referenced this pull request Sep 11, 2019
asfgit pushed a commit that referenced this pull request Sep 16, 2019
asfgit pushed a commit that referenced this pull request Sep 17, 2019
asfgit pushed a commit that referenced this pull request Sep 18, 2019
asfgit pushed a commit that referenced this pull request Sep 20, 2019
asfgit pushed a commit that referenced this pull request Sep 24, 2019
asfgit pushed a commit that referenced this pull request Oct 5, 2019
asfgit pushed a commit that referenced this pull request Oct 28, 2019
asfgit pushed a commit that referenced this pull request Nov 5, 2019
asfgit pushed a commit that referenced this pull request Nov 10, 2019
asfgit pushed a commit that referenced this pull request Nov 13, 2019
asfgit pushed a commit that referenced this pull request Dec 24, 2019
asfgit pushed a commit that referenced this pull request Feb 2, 2020
asfgit pushed a commit that referenced this pull request Feb 3, 2020
asfgit pushed a commit that referenced this pull request Feb 4, 2020
asfgit pushed a commit that referenced this pull request Feb 6, 2020
asfgit pushed a commit that referenced this pull request Feb 7, 2020
asfgit pushed a commit that referenced this pull request Feb 8, 2020
asfgit pushed a commit that referenced this pull request Feb 9, 2020
asfgit pushed a commit that referenced this pull request Feb 12, 2020
asfgit pushed a commit that referenced this pull request Feb 20, 2020
asfgit pushed a commit that referenced this pull request Feb 22, 2020
asfgit pushed a commit that referenced this pull request Feb 25, 2020
asfgit pushed a commit that referenced this pull request Feb 26, 2020
asfgit pushed a commit that referenced this pull request Feb 29, 2020
Apache9 added a commit that referenced this pull request Mar 2, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants