HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone #4634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are still 4 warnings left. For the two metrics one, I do not find a better way to fix, as the scheduleWithFixedRate will return a ScheduledFuture, seems the way is to store it somewhere and cancel it when stop? And in AssignmentManager, the problem is moveAsync just returns a Future, not a CompletableFuture, so there is no way to register a listener to log the errors if any. We can fix this in the future to let it returns a CompletableFuture, but better in another issue. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Ping @apurtell . PTAL at this one? Thanks. |
apurtell
approved these changes
Jul 25, 2022
| Promise<Void> saslPromise = channel.eventLoop().newPromise(); | ||
| trySaslNegotiate(conf, channel, dnInfo, timeoutMs, client, accessToken, saslPromise); | ||
| saslPromise.addListener(new FutureListener<Void>() { | ||
| addListener(saslPromise, new FutureListener<Void>() { |
Contributor
There was a problem hiding this comment.
"Promoting" the listener makes sense.
| state = State.BROKEN; | ||
| failWaitingAckQueue(channel, errorSupplier); | ||
| datanodeInfoMap.keySet().forEach(ChannelOutboundInvoker::close); | ||
| datanodeInfoMap.keySet().forEach(NettyFutureUtils::safeClose); |
Contributor
There was a problem hiding this comment.
I like the approach here where new NettyFutureUtils encapsulates the await/cleanup details, (edit: and suppresses warnings in one place, mostly.)
hbase-common/src/main/java/org/apache/hadoop/hbase/util/FutureUtils.java
Outdated
Show resolved
Hide resolved
| * thrown from the code that completes the future, and this method will catch all the exception | ||
| * thrown from the {@code listener} to catch possible code bugs. | ||
| * <p/> | ||
| * And the error phone check will always report FutureReturnValueIgnored because every method in |
hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/HttpProxyExample.java
Show resolved
Hide resolved
Contributor
|
@Apache9 Apologies for the delay, lgtm with minor comments |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The failed UT seems not related. Let me merge. |
Apache9
added a commit
that referenced
this pull request
Jul 26, 2022
…4634) Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit 8b091c4)
Apache9
added a commit
that referenced
this pull request
Jul 26, 2022
…4634) Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit 8b091c4)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…pache#4634) This change backports the changes from Jira: HBASE-27222. Signed-off-by: Andrew Purtell <[email protected]> (cherry picked from commit 8b091c4) (cherry picked from commit 84e7cdb) Change-Id: Ibd7bbaab22dcec49a25ad61ec43c7eac3365e902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.