Skip to content

HBASE-27183 Support regionserver to connect to HMaster proxy port #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
virajjasani wants to merge 1 commit into from
Closed

HBASE-27183 Support regionserver to connect to HMaster proxy port #4606

virajjasani wants to merge 1 commit into from

Conversation

@virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Jul 9, 2022 •
edited
Loading

Regionservers get active master address from Zookeeper/Master registry and tries to make RPC calls to master.

For security concerns, regionservers might require making connection to a different proxy port of master rather than it's original port retrieved from Zookeeper.

Configs:

  1. hbase.master.expose.proxy.port: Master can use this config (int) to expose new proxy port on active and backup master znodes.
  2. hbase.client.consume.master.proxy.port: Clients/Regionservers can use this config (boolean) to determine whether to connect to active master on new proxy port that master has exposed or continue using original port of master for connection.

@virajjasani virajjasani requested review from Apache9 and apurtell July 9, 2022 02:39
@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 1s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s master passed
+1 💚 compile 3m 36s master passed
+1 💚 checkstyle 0m 48s master passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 3m 31s the patch passed
+1 💚 cc 3m 31s the patch passed
+1 💚 javac 3m 31s the patch passed
-0 ⚠️ checkstyle 0m 31s hbase-server: The patch generated 1 new + 11 unchanged - 0 fixed = 12 total (was 11)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 25s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 hbaseprotoc 1m 17s the patch passed
-1 ❌ spotless 0m 18s patch has 64 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 4m 39s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 28s The patch does not generate ASF License warnings.
42m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4606
Optional Tests dupname asflicense cc hbaseprotoc spotless prototool javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 4dfac6595373 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 69 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 26s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 1m 26s master passed
+1 💚 shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 42s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 31s the patch passed
+1 💚 compile 1m 25s the patch passed
+1 💚 javac 1m 25s the patch passed
+1 💚 shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s hbase-zookeeper generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 unit 0m 32s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 36s hbase-zookeeper in the patch passed.
+1 💚 unit 195m 44s hbase-server in the patch passed.
217m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4606
Optional Tests unit javac javadoc shadedjars compile
uname Linux 0f035b50aa88 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-zookeeper.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/testReport/
Max. process+thread count 3004 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 22s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 31s master passed
+1 💚 compile 1m 23s master passed
+1 💚 shadedjars 3m 51s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 24s the patch passed
+1 💚 compile 1m 22s the patch passed
+1 💚 javac 1m 22s the patch passed
+1 💚 shadedjars 3m 52s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 41s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 0m 37s hbase-zookeeper in the patch passed.
+1 💚 unit 220m 31s hbase-server in the patch passed.
242m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4606
Optional Tests unit javac javadoc shadedjars compile
uname Linux 5c30f769ad85 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/testReport/
Max. process+thread count 2968 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani closed this Jul 9, 2022
@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 17s master passed
+1 💚 compile 4m 40s master passed
+1 💚 checkstyle 1m 15s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 27s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 16s the patch passed
+1 💚 compile 4m 40s the patch passed
+1 💚 cc 4m 40s the patch passed
+1 💚 javac 4m 40s the patch passed
-0 ⚠️ checkstyle 0m 31s hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 21s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 hbaseprotoc 1m 47s the patch passed
-1 ❌ spotless 0m 14s patch has 23 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 5m 57s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
49m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4606
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 7895ad696c8b 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 9s Maven dependency ordering for branch
+1 💚 mvninstall 2m 26s master passed
+1 💚 compile 1m 57s master passed
+1 💚 shadedjars 3m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 34s the patch passed
+1 💚 compile 1m 56s the patch passed
+1 💚 javac 1m 56s the patch passed
+1 💚 shadedjars 3m 55s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 11s hbase-zookeeper generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 unit 0m 32s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 38s hbase-common in the patch passed.
+1 💚 unit 1m 20s hbase-client in the patch passed.
+1 💚 unit 0m 36s hbase-zookeeper in the patch passed.
+1 💚 unit 196m 48s hbase-server in the patch passed.
222m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4606
Optional Tests javac javadoc unit shadedjars compile
uname Linux 25f73a30aca9 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-zookeeper.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/testReport/
Max. process+thread count 3012 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jul 9, 2022

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 29s master passed
+1 💚 compile 1m 59s master passed
+1 💚 shadedjars 3m 49s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 19s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 18s the patch passed
+1 💚 compile 1m 59s the patch passed
+1 💚 javac 1m 59s the patch passed
+1 💚 shadedjars 3m 47s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 15s the patch passed
_ Other Tests _
+1 💚 unit 0m 30s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 34s hbase-common in the patch passed.
+1 💚 unit 1m 11s hbase-client in the patch passed.
+1 💚 unit 0m 39s hbase-zookeeper in the patch passed.
+1 💚 unit 216m 24s hbase-server in the patch passed.
243m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4606
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6bd876d4b6e1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2197b38
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/testReport/
Max. process+thread count 2734 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4606/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apurtell apurtell Awaiting requested review from apurtell

@Apache9 Apache9 Awaiting requested review from Apache9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani @Apache-HBase