Skip to content

HBASE-27123 Splitting region may become RIT for 20 minutes when meta region is moved during split #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EungsopYoo wants to merge 2 commits into from
Closed

HBASE-27123 Splitting region may become RIT for 20 minutes when meta region is moved during split #4537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62a9429
fix RIT caused by meta region move during split
terence-yoo Jun 13, 2022
cdf7613
fix checkstyle violation
terence-yoo Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ protected Message callExecService(RpcController controller,
public CoprocessorServiceResponse call(int callTimeout) throws Exception {
if (rpcController instanceof HBaseRpcController) {
HBaseRpcController hrc = (HBaseRpcController) rpcController;
hrc.reset();
hrc.setPriority(tableName);
hrc.setCallTimeout(callTimeout);
}
Expand Down
49 changes: 49 additions & 0 deletions ...ver/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.Abortable;
import org.apache.hadoop.hbase.ClusterStatus;
import org.apache.hadoop.hbase.CoordinatedStateManager;
import org.apache.hadoop.hbase.Coprocessor;
import org.apache.hadoop.hbase.CoprocessorEnvironment;
Expand Down Expand Up @@ -1482,6 +1483,54 @@ public boolean evaluate() throws Exception {
}
}

@Test(timeout = 60000)
public void testMetaRegionMoveDuringSplit() throws Exception {
final TableName tableName = TableName.valueOf("testMetaRegionMoveDuringSplit");
try {
this.admin.setBalancerRunning(false, true);

ServerName rs1, rs2, rs3;
ClusterStatus status = TESTING_UTIL.getHBaseClusterInterface().getClusterStatus();
ArrayList<ServerName> serverNames = new ArrayList<>(status.getServers());
rs1 = serverNames.get(0);
rs2 = serverNames.get(1);
rs3 = serverNames.get(2);

// Move meta region to rs1
admin.move(Bytes.toBytes("1588230740"), Bytes.toBytes(rs1.getServerName()));
TESTING_UTIL.waitUntilNoRegionsInTransition(60000);

// Create test table
try(Table t = createTableAndWait(tableName, Bytes.toBytes("cf"))) {
insertData(tableName, admin, t);
}

// Move test table to rs2 that is different from the RS of meta region.
// This will cause the problem.
List<HRegion> regions = cluster.getRegions(tableName);
final HRegionInfo hri = getAndCheckSingleTableRegion(regions);
admin.move(hri.getEncodedNameAsBytes(), Bytes.toBytes(rs2.getServerName()));
TESTING_UTIL.waitUntilNoRegionsInTransition(60000);

// Find a splittable region
regions = cluster.getRegions(tableName);
final HRegion region = findSplittableRegion(regions);
assertNotNull("not able to find a splittable region", region);

// Split
this.admin.split(region.getRegionInfo().getRegionName(), new byte[] {42});

// Move meta region from rs1 to rs3 during split
this.admin.move(Bytes.toBytes("1588230740"), Bytes.toBytes(rs3.getServerName()));

LOG.info("Waiting for region to come out of RIT");
TESTING_UTIL.waitUntilNoRegionsInTransition(60000);
} finally {
admin.setBalancerRunning(true, false);
TESTING_UTIL.deleteTable(tableName);
}
}

public static class MockedCoordinatedStateManager extends ZkCoordinatedStateManager {

public void initialize(Server server, HRegion region) {
Expand Down