Skip to content

HBASE-26840 Fix NPE in the retry of logroller #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunhelly merged 2 commits into from
Mar 15, 2022
Merged

HBASE-26840 Fix NPE in the retry of logroller #4224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0247b0
HBASE-26840 Fix NPE in the retry of logroller
sunhelly Mar 15, 2022
443891e
remove {} for exception stacktrace
sunhelly Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@ public void run() {
if (waitingTime < rollWaitTimeout && nAttempts < maxRollRetry) {
nAttempts++;
LOG.warn("Retry to roll log, nAttempts={}, waiting time={}ms, sleeping 1s to retry,"
+ " last excepiton= {}", nAttempts, waitingTime,
ioe.getCause().getClass().getSimpleName());
+ " last exception", nAttempts, waitingTime, ioe);
sleep(1000);
} else {
LOG.error("Roll wal failed and waiting timeout, will not retry", ioe);
Expand Down