Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
public class StoreHotnessProtector {
private static final Logger LOG = LoggerFactory.getLogger(StoreHotnessProtector.class);

// We want to log just once so that users are aware of this tool
private static volatile boolean loggedDisableMessage;

private volatile int parallelPutToStoreThreadLimit;
Expand Down Expand Up @@ -98,12 +97,23 @@ public void init(Configuration conf) {
conf.getInt(PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_COUNT,
DEFAULT_PARALLEL_PUT_STORE_THREADS_LIMIT_MIN_COLUMN_NUM);

if (!isEnable() && !loggedDisableMessage) {
loggedDisableMessage = true;
if (!isEnable()) {
logDisabledMessageOnce();
}
}

/**
* {@link #init(Configuration)} is called for every Store that opens on a RegionServer.
* Here we make a lightweight attempt to log this message once per RegionServer, rather than
* per-Store. The goal is just to draw attention to this feature if debugging overload due to
* heavy writes.
*/
private static void logDisabledMessageOnce() {
if (!loggedDisableMessage) {
LOG.info("StoreHotnessProtector is disabled. Set {} > 0 to enable, "
+ "which may help mitigate load under heavy write pressure.",
PARALLEL_PUT_STORE_THREADS_LIMIT);
loggedDisableMessage = true;
}
}

Expand Down