Skip to content

HBASE-26767 Rest server should not use a large Header Cache. #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ss77892 wants to merge 2 commits into from
Closed

HBASE-26767 Rest server should not use a large Header Cache. #4123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e26ef8
HBASE-26767 Rest server should not use a large Header Cache.
ss77892 Feb 23, 2022
62079dc
Update hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServ…
ss77892 Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ public class RESTServer implements Constants {
static final String REST_CSRF_METHODS_TO_IGNORE_DEFAULT = "GET,OPTIONS,HEAD,TRACE";
public static final String SKIP_LOGIN_KEY = "hbase.rest.skip.login";
static final int DEFAULT_HTTP_MAX_HEADER_SIZE = 64 * 1024; // 64k
static final String HTTP_HEADER_CACHE_SIZE = "hbase.rest.http.header.cache.size";
static final int DEFAULT_HTTP_HEADER_CACHE_SIZE = Character.MAX_VALUE -1;

private static final String PATH_SPEC_ANY = "/*";

Expand Down Expand Up @@ -291,10 +293,12 @@ public synchronized void run() throws Exception {

String host = servlet.getConfiguration().get("hbase.rest.host", "0.0.0.0");
int servicePort = servlet.getConfiguration().getInt("hbase.rest.port", 8080);
int httpHeaderCacheSize = servlet.getConfiguration().getInt(HTTP_HEADER_CACHE_SIZE,
DEFAULT_HTTP_HEADER_CACHE_SIZE);
HttpConfiguration httpConfig = new HttpConfiguration();
httpConfig.setSecureScheme("https");
httpConfig.setSecurePort(servicePort);
httpConfig.setHeaderCacheSize(DEFAULT_HTTP_MAX_HEADER_SIZE);
httpConfig.setHeaderCacheSize(httpHeaderCacheSize);
httpConfig.setRequestHeaderSize(DEFAULT_HTTP_MAX_HEADER_SIZE);
httpConfig.setResponseHeaderSize(DEFAULT_HTTP_MAX_HEADER_SIZE);
httpConfig.setSendServerVersion(false);
Expand Down