Skip to content

HBASE-22739 check bound where removeRegion #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
casuallc wants to merge 1 commit into from
Closed

HBASE-22739 check bound where removeRegion #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,9 @@ int[] removeRegion(int[] regions, int regionIndex) {
if (regions[i] == regionIndex) {
break;
}
if (i == regions.length - 1) {
return Arrays.copyOf(regions, regions.length);
Copy link
Contributor

@Reidddddd Reidddddd Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here i think we can just return regions. No need to copy the entire array, unless you have a strong reason.

}
newRegions[i] = regions[i];
}
System.arraycopy(regions, i+1, newRegions, i, newRegions.length - i);
Expand Down