HBASE-22132 : Backport HBASE-22115 to branch-1 #395

virajjasani · 2019-07-20T13:57:17Z

TraceScope for reclaimMemStoreMemory to be wrapped around by try-with-resources so that any Exception in reclaimMemStoreMemory() does not leave scope opened

Apache-HBase · 2019-07-20T21:05:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	65	Docker mode activated.
		_ Prechecks _
0	findbugs	1	Findbugs executables are not available.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	133	branch-1 passed
+1	compile	39	branch-1 passed with JDK v1.8.0_222
+1	compile	38	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	70	branch-1 passed
+1	shadedjars	154	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	29	branch-1 passed with JDK v1.8.0_222
+1	javadoc	35	branch-1 passed with JDK v1.7.0_232
		_ Patch Compile Tests _
+1	mvninstall	94	the patch passed
+1	compile	36	the patch passed with JDK v1.8.0_222
+1	javac	36	the patch passed
+1	compile	38	the patch passed with JDK v1.7.0_232
+1	javac	38	the patch passed
+1	checkstyle	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	154	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	191	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	27	the patch passed with JDK v1.8.0_222
+1	javadoc	35	the patch passed with JDK v1.7.0_232
		_ Other Tests _
-1	unit	9554	hbase-server in the patch failed.
+1	asflicense	24	The patch does not generate ASF License warnings.
		10951

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.client.TestAdmin1

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/1/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4456d786ace3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	branch-1 / `0a5fe60`
maven	version: Apache Maven 3.0.5
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/1/testReport/
Max. process+thread count	4297 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-22T10:22:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1342	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	1	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	141	branch-1 passed
+1	compile	50	branch-1 passed with JDK v1.8.0_222
+1	compile	55	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	111	branch-1 passed
+1	shadedjars	213	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	37	branch-1 passed with JDK v1.8.0_222
+1	javadoc	49	branch-1 passed with JDK v1.7.0_232
0	spotbugs	203	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	199	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	134	the patch passed
+1	compile	49	the patch passed with JDK v1.8.0_222
+1	javac	49	the patch passed
+1	compile	52	the patch passed with JDK v1.7.0_232
+1	javac	52	the patch passed
+1	checkstyle	114	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	245	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	298	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	39	the patch passed with JDK v1.8.0_222
+1	javadoc	49	the patch passed with JDK v1.7.0_232
+1	findbugs	229	the patch passed
		_ Other Tests _
-1	unit	11146	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		14806

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.regionserver.TestRegionReplicaFailover

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 297d50b997a5 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `28de85f`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/testReport/
Max. process+thread count	4447 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T12:30:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	2380	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	226	branch-1 passed
+1	compile	55	branch-1 passed with JDK v1.8.0_222
+1	compile	59	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	133	branch-1 passed
+1	shadedjars	248	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	43	branch-1 passed with JDK v1.8.0_222
+1	javadoc	52	branch-1 passed with JDK v1.7.0_232
0	spotbugs	240	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	236	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	155	the patch passed
+1	compile	54	the patch passed with JDK v1.8.0_222
+1	javac	54	the patch passed
+1	compile	61	the patch passed with JDK v1.7.0_232
+1	javac	61	the patch passed
+1	checkstyle	128	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	235	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	314	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	41	the patch passed with JDK v1.8.0_222
+1	javadoc	54	the patch passed with JDK v1.7.0_232
+1	findbugs	246	the patch passed
		_ Other Tests _
-1	unit	10817	hbase-server in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		15860

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestMasterBalanceThrottling
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux b40a87fe6cdc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `0d8f9b5`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/testReport/
Max. process+thread count	3981 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T16:26:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1322	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	172	branch-1 passed
+1	compile	46	branch-1 passed with JDK v1.8.0_222
+1	compile	48	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	93	branch-1 passed
+1	shadedjars	190	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	31	branch-1 passed with JDK v1.8.0_222
+1	javadoc	44	branch-1 passed with JDK v1.7.0_232
0	spotbugs	179	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	177	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	114	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_222
+1	javac	38	the patch passed
+1	compile	45	the patch passed with JDK v1.7.0_232
+1	javac	45	the patch passed
+1	checkstyle	92	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	182	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	270	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	32	the patch passed with JDK v1.8.0_222
+1	javadoc	41	the patch passed with JDK v1.7.0_232
+1	findbugs	174	the patch passed
		_ Other Tests _
-1	unit	9519	hbase-server in the patch failed.
+1	asflicense	23	The patch does not generate ASF License warnings.
		12856

Reason	Tests
Failed junit tests	hadoop.hbase.replication.TestReplicationSmallTests
	hadoop.hbase.master.TestMasterMetrics
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/3/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 0024ed9a1d4a 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `d38078a`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/3/testReport/
Max. process+thread count	4215 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-23T22:03:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	91	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	148	branch-1 passed
+1	compile	56	branch-1 passed with JDK v1.8.0_222
+1	compile	51	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	104	branch-1 passed
+1	shadedjars	205	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	branch-1 passed with JDK v1.8.0_222
+1	javadoc	50	branch-1 passed with JDK v1.7.0_232
0	spotbugs	202	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	197	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	134	the patch passed
+1	compile	49	the patch passed with JDK v1.8.0_222
+1	javac	49	the patch passed
+1	compile	54	the patch passed with JDK v1.7.0_232
+1	javac	54	the patch passed
+1	checkstyle	111	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	204	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	271	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	39	the patch passed with JDK v1.8.0_222
+1	javadoc	49	the patch passed with JDK v1.7.0_232
+1	findbugs	215	the patch passed
		_ Other Tests _
+1	unit	9128	hbase-server in the patch passed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		11453

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/5/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 401cab05f1ee 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `f7bdf76`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/5/testReport/
Max. process+thread count	4864 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/5/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-24T13:49:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1143	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	121	branch-1 passed
+1	compile	37	branch-1 passed with JDK v1.8.0_222
+1	compile	41	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	90	branch-1 passed
+1	shadedjars	163	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	27	branch-1 passed with JDK v1.8.0_222
+1	javadoc	39	branch-1 passed with JDK v1.7.0_232
0	spotbugs	161	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	158	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	121	the patch passed
+1	compile	41	the patch passed with JDK v1.8.0_222
+1	javac	41	the patch passed
+1	compile	44	the patch passed with JDK v1.7.0_232
+1	javac	44	the patch passed
+1	checkstyle	86	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	174	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	241	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	28	the patch passed with JDK v1.8.0_222
+1	javadoc	39	the patch passed with JDK v1.7.0_232
+1	findbugs	169	the patch passed
		_ Other Tests _
-1	unit	8193	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		11172

Reason	Tests
Failed junit tests	hadoop.hbase.master.TestMasterMetrics

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/6/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux c2d8098d6fb2 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `e1427d1`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/6/testReport/
Max. process+thread count	4110 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/6/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

virajjasani · 2019-07-24T17:42:06Z

Please review @apurtell

Apache-HBase · 2019-07-24T22:22:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	80	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	1	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	104	branch-1 passed
+1	compile	38	branch-1 passed
+1	checkstyle	94	branch-1 passed
-1	shadedjars	10	branch has 10 errors when building our shaded downstream artifacts.
+1	javadoc	30	branch-1 passed
0	spotbugs	130	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	127	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	95	the patch passed
+1	compile	38	the patch passed
+1	javac	38	the patch passed
+1	checkstyle	86	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
-1	shadedjars	10	patch has 10 errors when building our shaded downstream artifacts.
+1	hadoopcheck	203	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	31	the patch passed
+1	findbugs	152	the patch passed
		_ Other Tests _
-1	unit	8454	hbase-server in the patch failed.
+1	asflicense	19	The patch does not generate ASF License warnings.
		9754

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.master.TestMasterBalanceThrottling

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux aeb7e2f99d78 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `3e7c945`
Default Java	1.8.0_222
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/artifact/out/branch-shadedjars.txt
shadedjars	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/artifact/out/patch-shadedjars.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/testReport/
Max. process+thread count	4582 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/7/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-07-25T00:58:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	115	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	150	branch-1 passed
+1	compile	49	branch-1 passed with JDK v1.8.0_222
+1	compile	45	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	89	branch-1 passed
+1	shadedjars	176	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	34	branch-1 passed with JDK v1.8.0_222
+1	javadoc	40	branch-1 passed with JDK v1.7.0_232
0	spotbugs	172	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	167	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	132	the patch passed
+1	compile	38	the patch passed with JDK v1.8.0_222
+1	javac	38	the patch passed
+1	compile	44	the patch passed with JDK v1.7.0_232
+1	javac	44	the patch passed
+1	checkstyle	86	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	171	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	232	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	42	the patch passed with JDK v1.7.0_232
+1	findbugs	176	the patch passed
		_ Other Tests _
-1	unit	8375	hbase-server in the patch failed.
+1	asflicense	25	The patch does not generate ASF License warnings.
		10417

Reason	Tests
Failed junit tests	hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/8/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 32cb85fc6590 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `c3a8f6c`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/8/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/8/testReport/
Max. process+thread count	3999 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/8/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Reidddddd · 2019-07-25T04:44:17Z

LGTM, will commit it late this day if no further comment.

apurtell

lgtm, will commit

Signed-off-by: Reid Chan <[email protected]> Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java

Apache-HBase · 2019-07-25T19:01:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	1571	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1	mvninstall	166	branch-1 passed
+1	compile	40	branch-1 passed with JDK v1.8.0_222
+1	compile	42	branch-1 passed with JDK v1.7.0_232
+1	checkstyle	86	branch-1 passed
+1	shadedjars	168	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	32	branch-1 passed with JDK v1.8.0_222
+1	javadoc	37	branch-1 passed with JDK v1.7.0_232
0	spotbugs	153	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	151	branch-1 passed
		_ Patch Compile Tests _
+1	mvninstall	102	the patch passed
+1	compile	41	the patch passed with JDK v1.8.0_222
+1	javac	41	the patch passed
+1	compile	43	the patch passed with JDK v1.7.0_232
+1	javac	43	the patch passed
+1	checkstyle	81	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	181	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	232	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1	javadoc	29	the patch passed with JDK v1.8.0_222
+1	javadoc	39	the patch passed with JDK v1.7.0_232
+1	findbugs	172	the patch passed
		_ Other Tests _
-1	unit	9266	hbase-server in the patch failed.
+1	asflicense	40	The patch does not generate ASF License warnings.
		12715

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestEncryptionKeyRotation
	hadoop.hbase.master.TestMasterBalanceThrottling

Subsystem	Report/Notes
Docker	Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/9/artifact/out/Dockerfile
GITHUB PR	#395
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 49bc30f52db5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-395/out/precommit/personality/provided.sh
git revision	branch-1 / `cbb9614`
Default Java	1.7.0_232
Multi-JDK versions	/usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/9/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/9/testReport/
Max. process+thread count	5220 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-395/9/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HBASE-22132 : Backport HBASE-22115 to branch-1

22810c9

Reidddddd approved these changes Jul 25, 2019

View reviewed changes

apurtell approved these changes Jul 25, 2019

View reviewed changes

apurtell merged commit 2be03e1 into apache:branch-1 Jul 25, 2019

HBASE-22132 : Backport HBASE-22115 to branch-1 #395

HBASE-22132 : Backport HBASE-22115 to branch-1 #395

Uh oh!

Conversation

virajjasani commented Jul 20, 2019

Uh oh!

Apache-HBase commented Jul 20, 2019

Uh oh!

Apache-HBase commented Jul 22, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 23, 2019

Uh oh!

Apache-HBase commented Jul 24, 2019

Uh oh!

virajjasani commented Jul 24, 2019

Uh oh!

Apache-HBase commented Jul 24, 2019

Uh oh!

Apache-HBase commented Jul 25, 2019

Uh oh!

Reidddddd commented Jul 25, 2019

Uh oh!

apurtell left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Jul 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants