HBASE-26450 Server configuration will overwrite HStore configuration … #3843

GeorryHuang · 2021-11-11T10:37:40Z

…After using shell command 'updateConfiguration'

Apache-HBase · 2021-11-11T11:28:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	3m 15s	master passed
+1 💚	checkstyle	1m 5s	master passed
+1 💚	spotbugs	2m 6s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	3m 12s	the patch passed
+1 💚	javac	3m 12s	the patch passed
+1 💚	checkstyle	1m 3s	hbase-server: The patch generated 0 new + 29 unchanged - 2 fixed = 29 total (was 31)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 40s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		49m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux c01573cf5a63 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cb3ecf6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-11T13:30:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	shadedjars	8m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	8m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	139m 47s	hbase-server in the patch passed.
		172m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e3ff91c515c1 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cb3ecf6`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/testReport/
Max. process+thread count	3488 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

+1. Nice catch.

Apache9 · 2021-11-11T14:35:55Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

-    this.storeEngine.compactionPolicy.setConf(conf);
-    this.offPeakHours = OffPeakHours.getInstance(conf);
+    this.conf = storeConf;
+    this.storeEngine.compactionPolicy.setConf(storeConf);


OK, so the problem is here, the 'conf' here is the conf from the parameter, not 'this.conf'...

Apache-HBase · 2021-11-11T14:44:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 31s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	9m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 17s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	9m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	212m 24s	hbase-server in the patch passed.
		245m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c0fad6347f9f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `cb3ecf6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/testReport/
Max. process+thread count	2549 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ

+1

…uration … (#3843)" This reverts commit 628b8b7.

…after using shell command 'update_config' (#3843) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Baiqiang Zhao <[email protected]>

Apache-HBase · 2021-11-12T03:56:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 49s	master passed
+1 💚	compile	3m 14s	master passed
+1 💚	checkstyle	1m 3s	master passed
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	3m 11s	the patch passed
+1 💚	javac	3m 11s	the patch passed
+1 💚	checkstyle	1m 3s	hbase-server: The patch generated 0 new + 29 unchanged - 2 fixed = 29 total (was 31)
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	19m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		48m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e47b6b71dc32 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f24484d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-12T06:06:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	8m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	147m 32s	hbase-server in the patch passed.
		178m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 512f2c715a23 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f24484d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/testReport/
Max. process+thread count	3753 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-12T07:13:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 21s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	shadedjars	9m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 55s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 5s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	9m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	209m 27s	hbase-server in the patch passed.
		245m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3843
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1e76d6c5695d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f24484d`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/testReport/
Max. process+thread count	2529 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3843/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…after using shell command 'update_config' (#3843) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Baiqiang Zhao <[email protected]>

…after using shell command 'update_config' (apache#3843) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Baiqiang Zhao <[email protected]>

HBASE-26450 Server configuration will overwrite HStore configuration …

be1d9f3

…After using shell command 'updateConfiguration'

Apache9 approved these changes Nov 11, 2021

View reviewed changes

ZhaoBQ approved these changes Nov 12, 2021

View reviewed changes

formate code

51111d6

GeorryHuang merged commit 628b8b7 into apache:master Nov 12, 2021

GeorryHuang added a commit that referenced this pull request Nov 12, 2021

Revert "HBASE-26450 Server configuration will overwrite HStore config…

8828f75

…uration … (#3843)" This reverts commit 628b8b7.

asfgit pushed a commit that referenced this pull request Nov 12, 2021

Revert "HBASE-26450 Server configuration will overwrite HStore config…

058d3a4

…uration … (#3843)" This reverts commit 628b8b7.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26450 Server configuration will overwrite HStore configuration … #3843

HBASE-26450 Server configuration will overwrite HStore configuration … #3843

Uh oh!

GeorryHuang commented Nov 11, 2021

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

Apache9 left a comment

Uh oh!

Apache9 Nov 11, 2021

Uh oh!

GeorryHuang Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

ZhaoBQ left a comment

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-26450 Server configuration will overwrite HStore configuration … #3843

HBASE-26450 Server configuration will overwrite HStore configuration … #3843

Uh oh!

Conversation

GeorryHuang commented Nov 11, 2021

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 Nov 11, 2021

Choose a reason for hiding this comment

Uh oh!

GeorryHuang Nov 12, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 11, 2021

Uh oh!

ZhaoBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants