HBASE-26406 Can not add peer replicating to non-HBase #3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
shahrs87
reviewed
Oct 29, 2021
Contributor
shahrs87
left a comment
shahrs87
left a comment
There was a problem hiding this comment.
Overall looks good to me, just couple of questions.
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestNonHBaseReplicationEndpoint.class); | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(TestNonHBaseReplicationEndpoint.class); |
Contributor
There was a problem hiding this comment.
nit: LOG not used anywhere.
| // Default is HBaseInterClusterReplicationEndpoint and only it need to check cluster key | ||
| if (endpoint == null || endpoint instanceof HBaseInterClusterReplicationEndpoint) { | ||
| // Endpoints implementing HBaseReplicationEndpoint need to check cluster key | ||
| if (endpoint == null || endpoint instanceof HBaseReplicationEndpoint) { |
Contributor
There was a problem hiding this comment.
As for this issue, it doesn't matter whether it is an instance of HBaseInterClusterReplicationEndpoint or HBaseReplicationEndpoint, correct ? since the test is skipping the check completely.
Member
Author
There was a problem hiding this comment.
The reason I modified here is that the target of HBaseReplicationEndpoint is an HBase cluster, for all its implementations including HBaseInterClusterReplicationEndpoint, we should check clusterKey.
| } | ||
|
|
||
| private void checkClusterId(String clusterKey) throws DoNotRetryIOException { | ||
| private void checkSameClusterKey(String clusterKey) throws DoNotRetryIOException { |
Contributor
There was a problem hiding this comment.
This method is checking whether cluster id is same or not, so IMO the method name is correct. We can change it to checkSameClusterId if you like.
Member
Author
There was a problem hiding this comment.
The original method name checkClusterId is inappropriate, clusterId and clusterKey are not the same thing in replication, So I kept the same style as the above method checkClusterKey and renamed it checkSameClusterKey.
| } | ||
| } | ||
|
|
||
| public static class NonHBaseReplicationEndpoint extends BaseReplicationEndpoint { |
Contributor
There was a problem hiding this comment.
Just curious, BaseReplicationEndpoint's InterfaceAudience is Private and so is HBaseInterClusterReplicationEndpoint and HBaseReplicationEndpoint's IA. If anyone wants to implement its custom ReplicationEndPoint, should we think to make it LimitedPrivate with HBaseInterfaceAudience as REPLICATION.
Member
Author
There was a problem hiding this comment.
The answer should be in HBASE-15982, made HBaseReplicationEndpoint and BaseReplicationEndpoint as Private since want to internalize Guava's API, so custom Endpoint should implement ReplicationEndpoint.
I was not aware of this problem before, I should make NonHBaseReplicationEndpoint implement ReplicationEndpoint.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Nov 1, 2021
| // Default is HBaseInterClusterReplicationEndpoint and only it need to check cluster key | ||
| if (endpoint == null || endpoint instanceof HBaseInterClusterReplicationEndpoint) { | ||
| // Endpoints implementing HBaseReplicationEndpoint need to check cluster key | ||
| if (endpoint == null || endpoint instanceof HBaseReplicationEndpoint) { |
Contributor
|
Please fix the checkstyle issue before merging. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ddupg
added a commit
to ddupg/hbase
that referenced
this pull request
Nov 2, 2021
Signed-off-by: Rushabh Shah <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit b9b7fec)
ddupg
added a commit
that referenced
this pull request
Nov 2, 2021
Signed-off-by: Rushabh Shah <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit b9b7fec)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Rushabh Shah <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit b9b7fec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed to add a peer replicating to non-HBase(like MQ) by implementing custom ReplicationEndpoint, got exception like this in my UT:
HBASE-24743 ignored this situation and introduced this bug.