HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17 #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 24, 2021
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 25, 2021
| private static final String JVMVersion = System.getProperty("java.version"); | ||
|
|
||
| private static final Float JREVersion = | ||
| Float.parseFloat(System.getProperty("java.specification.version")); |
Contributor
There was a problem hiding this comment.
We can not use the above 'java.version' to test whether it is JDK17?
Contributor
Author
There was a problem hiding this comment.
The above JVMVersion is a String like "1.8.0_302", which is not easy to be changed to a numeric variable. System.getProperty("java.specification.version") will only return String like "1", "8", "9", "10", "11", which can be easily parsed to a Float.
Contributor
There was a problem hiding this comment.
OK, got it. So why use Float here? I think it is just a integer?
Contributor
Author
There was a problem hiding this comment.
If the java is 7 or 8, the String will be "1.7" or "1.8". In this case, if we parse it to Integer, it will raise an exception.
Contributor
Author
There was a problem hiding this comment.
Only version > 9, will return an Integer friendly String.
Contributor
There was a problem hiding this comment.
OK. But maybe we'd better unify them to the same pattern? For example, we check whether the returned property contains a dot, if so, we just parse the last character as a int, otherwise parse the whole String. And for the field name, better name it as JVM_RELEASE_VERSION or JVM_SPEC_VERSION? And also add some comments to explain the meaning.
Contributor
Author
There was a problem hiding this comment.
OK, have added comments and rename the variable. I think it is easier to read and use. (Version 8 is represented by 1)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Oct 26, 2021
| * NOTE: Java 8 will be represented by 1. | ||
| */ | ||
| private static final int JVM_SPEC_VERSION = JVM_SPEC_VERSION_STRING.contains(".") ? | ||
| (int) Float.parseFloat(System.getProperty("java.specification.version")) : |
Contributor
There was a problem hiding this comment.
Why not just use the above JVM_SPEC_VERSION_STRING? And let's use substring and then parse 1.8 to 8? Or use float and multiply 10 and then minus 10 to get 8? It is a bit strange that we return 1 for 1.8...
Contributor
Author
There was a problem hiding this comment.
Refined the version number logic, it now return a int like 8, 9, 10,....
| return ibmvendor && JVMVersion.contains("1.6.0"); | ||
| } | ||
|
|
||
| public static float getJVMSpecVersion() { |
Contributor
Author
There was a problem hiding this comment.
Float legacy, have fixed in the latest commit.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Oct 27, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Oct 27, 2021
Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Oct 27, 2021
Signed-off-by: Duo Zhang <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Duo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-26392