HBASE-26371 Prioritize meta region move over other region moves in region_mover #3767

virajjasani · 2021-10-19T16:21:20Z

No description provided.

…gion_mover

Apache-HBase · 2021-10-19T17:23:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 17s	master passed
+1 💚	compile	3m 35s	master passed
+1 💚	checkstyle	1m 15s	master passed
+1 💚	spotbugs	2m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 41s	the patch passed
+1 💚	compile	3m 34s	the patch passed
-0 ⚠️	javac	3m 34s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
-0 ⚠️	checkstyle	1m 11s	hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	24m 43s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		61m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e609bd85675c 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26ab9d0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-19T19:29:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	shadedjars	8m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 25s	the patch passed
+1 💚	compile	1m 16s	the patch passed
+1 💚	javac	1m 16s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	155m 14s	hbase-server in the patch passed.
		187m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a8a33805a9dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26ab9d0`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/testReport/
Max. process+thread count	4184 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-19T20:31:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 29s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	9m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 17s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	9m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	216m 24s	hbase-server in the patch passed.
		249m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d816d06bec36 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `26ab9d0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/testReport/
Max. process+thread count	3768 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

apurtell

A minor comment, for your consideration

apurtell · 2021-10-19T21:28:14Z

hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java

  public boolean load() throws ExecutionException, InterruptedException, TimeoutException {
    ExecutorService loadPool = Executors.newFixedThreadPool(1);
-    Future<Boolean> loadTask = loadPool.submit(() -> {
+    Future<Boolean> loadTask = loadPool.submit(getRegionsMovePlan(true));


Rather than have a boolean parameter, which makes the code a little hard to understand, consider two methods (perhaps mostly sharing functionality via a common sibling method), one for making a META region move plan, if meta needs to be moved, and another for making a region move plan that excludes meta. E.g. getSystemRegionsMovePlan() vs getRegionsMovePlan(). Will make it a little easier to understand.

Sounds good, will address this soon.

Apache-HBase · 2021-10-20T10:44:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	3m 29s	master passed
+1 💚	checkstyle	1m 14s	master passed
+1 💚	spotbugs	2m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	3m 38s	the patch passed
+1 💚	javac	3m 38s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 51s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		55m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d206ee66c1d8 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e73ea8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-20T12:49:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 22s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	8m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 50s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	8m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	149m 16s	hbase-server in the patch passed.
		180m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fa4f633c8f71 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e73ea8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/testReport/
Max. process+thread count	5314 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-10-20T12:50:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	8m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 55s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	9m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	the patch passed
		_ Other Tests _
-1 ❌	unit	148m 6s	hbase-server in the patch failed.
		181m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5e20df5d2cd2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `9e73ea8`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/testReport/
Max. process+thread count	4009 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3767/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…gion_mover (#3771) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

…gion_mover (#3769) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

…gion_mover (#3768) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

…gion_mover (#3769) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

…gion_mover (apache#3769) (apache#3767) Signed-off-by: Andrew Purtell <[email protected]>

HBASE-26371 Prioritize meta region move over other region moves in re…

b665d27

…gion_mover

apurtell approved these changes Oct 19, 2021

View reviewed changes

addendum

94ec57d

virajjasani merged commit 856d08e into apache:master Oct 20, 2021

virajjasani added a commit that referenced this pull request Oct 20, 2021

HBASE-26371 Prioritize meta region move over other region moves in re…

5c4a053

…gion_mover (#3771) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

virajjasani added a commit that referenced this pull request Oct 20, 2021

HBASE-26371 Prioritize meta region move over other region moves in re…

09ffa49

…gion_mover (#3769) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

virajjasani added a commit that referenced this pull request Oct 20, 2021

HBASE-26371 Prioritize meta region move over other region moves in re…

ce938a1

…gion_mover (#3768) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

virajjasani added a commit that referenced this pull request Oct 20, 2021

HBASE-26371 Prioritize meta region move over other region moves in re…

75f47f7

…gion_mover (#3769) (#3767) Signed-off-by: Andrew Purtell <[email protected]>

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024

HBASE-26371 Prioritize meta region move over other region moves in re…

f1f883e

…gion_mover (apache#3769) (apache#3767) Signed-off-by: Andrew Purtell <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26371 Prioritize meta region move over other region moves in region_mover #3767

HBASE-26371 Prioritize meta region move over other region moves in region_mover #3767

Uh oh!

virajjasani commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

apurtell left a comment

Uh oh!

apurtell Oct 19, 2021

Uh oh!

virajjasani Oct 20, 2021

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HBASE-26371 Prioritize meta region move over other region moves in region_mover #3767

HBASE-26371 Prioritize meta region move over other region moves in region_mover #3767

Uh oh!

Conversation

virajjasani commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

Apache-HBase commented Oct 19, 2021

Uh oh!

apurtell left a comment

Choose a reason for hiding this comment

Uh oh!

apurtell Oct 19, 2021

Choose a reason for hiding this comment

Uh oh!

virajjasani Oct 20, 2021

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Apache-HBase commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants