HBASE-26190 High rate logging of Bucket Allocator Allocation fails #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anoopsjohn Please review |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Sep 10, 2021
|
|
||
| /* Tracing failed Bucket Cache allocations. */ | ||
| private long prevRecTE; // previous recorded time since Epoch in seconds | ||
| private static final int ALLOCATION_FAIL_TRACE_TIME_GAP = 60; // Default 60 seconds. |
Contributor
There was a problem hiding this comment.
Can keep this as millisec so that for below time check, you can just use System.currentTimeMillis() alone
Contributor
There was a problem hiding this comment.
Call it ALLOCATION_FAIL_LOG_TIME_PERIOD?
|
|
||
| /* Tracing failed Bucket Cache allocations. */ | ||
| private LongAdder allocationFailCount = new LongAdder(); | ||
| private LongAdder allocationFailSize = new LongAdder(); |
Contributor
There was a problem hiding this comment.
do we need this really? I believe alloc fail count is enough in stat
| // Presume can't add. Too big? Move index on. Entry will be cleared from ramCache below. | ||
| bucketEntries[index] = null; | ||
| index++; | ||
| prevRecTE = currTE; |
Contributor
There was a problem hiding this comment.
This will cause prevRecTE to set to curTS whenever BucketAllocatorException happens. We need to do that only when we log it
Contributor
Author
There was a problem hiding this comment.
Nice catch. Thanks.
| long currTE = System.currentTimeMillis()/1000; // Current time since Epoch in seconds. | ||
| // Record the warning. | ||
| cacheStats.allocationFailed(re.getData().getSerializedLength()); | ||
| if (prevRecTE == 0) { |
Contributor
There was a problem hiding this comment.
May be just a common log is enoug?
if( prevRecTE == 0 || currTE - prevRecTE > ALLOCATION_FAIL_TRACE_TIME_GAP)
KulwantSingh011
force-pushed
the
HBASE-26190_c
branch
from
cc919e9 to
6c124f0
Compare
KulwantSingh011
added a commit
to KulwantSingh011/hbase
that referenced
this pull request
Sep 14, 2021
Incorporated review comments as at apache#3648.
KulwantSingh011
added a commit
to KulwantSingh011/hbase
that referenced
this pull request
Sep 14, 2021
Incorporated review comments as at apache#3648.
KulwantSingh011
force-pushed
the
HBASE-26190_c
branch
from
6c124f0 to
99b9378
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
KulwantSingh011
force-pushed
the
HBASE-26190_c
branch
3 times, most recently
from
5b9214c to
5eb4160
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
KulwantSingh011
force-pushed
the
HBASE-26190_c
branch
from
5eb4160 to
3e6921d
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
… too big Reduce the frequency of allocation failed traces by printing them preiodically (once per minute). Record the allocation failures in the Bucket Cache Stats and let the stat thread dump cumulative allocation failures alongside other traces it dumps. Also, this change adds trace for the Table name, Column Family and HFileName for the most recent allocation failure in last 1 minute.
too big Moved the construction of the warning message to a seaparte method.
… too big Incorporated review comments regarding code formatting, name of a the getWarningMessage, and name of variables like tableName.
KulwantSingh011
force-pushed
the
HBASE-26190_c
branch
from
3e6921d to
afd2a43
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the frequency of allocation failed traces by printing them once
periodically. Record the allocation failures in the Bucket Cache Stats
and let the stat thread dump cumulative allocation failures alongside
other traces it dumps.