Skip to content

HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFuture… #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsglz merged 2 commits into from
Jul 1, 2021
Merged

HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFuture… #3419

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b284b5d
HBASE-26027 The calling of HTable.batch blocked at AsyncRequestFuture…
bsglz Jun 23, 2021
ee37def
fix review issue
bsglz Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,8 @@ private String buildDetailedErrorMsg(String string, int index) {
@Override
public void waitUntilDone() throws InterruptedIOException {
try {
waitUntilDone(Long.MAX_VALUE);
long cutoff = (EnvironmentEdgeManager.currentTime() + this.operationTimeout) * 1000L;
Copy link
Contributor

@Apache9 Apache9 Jun 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if operationTimeout here is negative(which means no timeout), or Long.MAX_VALUE?

Copy link
Contributor Author

@bsglz bsglz Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if operationTimeout here is negative(which means no timeout), or Long.MAX_VALUE?

Good point, exclude that cases seems better, will fix later, thanks.

Copy link
Contributor Author

@bsglz bsglz Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of operationTimeout is int, so seems no need to consider Long.MAX_VALUE case.

waitUntilDone(cutoff);
} catch (InterruptedException iex) {
throw new InterruptedIOException(iex.getMessage());
} finally {
Expand Down