HBASE-25984: Avoid premature reuse of sync futures in FSHLog (#3371) #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bharathv merged 1 commit into apache:branch-2.3 from bharathv:HBASE-25984-branch-2.3

Jun 17, 2021

Contributor

bharathv commented Jun 16, 2021

Signed-off-by: Viraj Jasani [email protected]
(cherry picked from commit 5a19bcf)

Apache-HBase commented Jun 17, 2021

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	4m 50s	branch-2.3 passed
+1 💚	compile	4m 3s	branch-2.3 passed
+1 💚	checkstyle	1m 28s	branch-2.3 passed
+1 💚	spotbugs	2m 51s	branch-2.3 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	3m 46s	the patch passed
+1 💚	javac	3m 46s	the patch passed
-0 ⚠️	checkstyle	1m 27s	hbase-server: The patch generated 2 new + 12 unchanged - 0 fixed = 14 total (was 12)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	24m 6s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.
+1 💚	spotbugs	3m 0s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		60m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4ffd352ee6c7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `6147c1c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase commented Jun 17, 2021

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	4m 45s	branch-2.3 passed
+1 💚	compile	1m 9s	branch-2.3 passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	branch-2.3 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	192m 12s	hbase-server in the patch passed.
		221m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ba575afc878f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `6147c1c`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/testReport/
Max. process+thread count	2525 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase commented Jun 17, 2021

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.3 Compile Tests _
+1 💚	mvninstall	4m 41s	branch-2.3 passed
+1 💚	compile	1m 13s	branch-2.3 passed
+1 💚	shadedjars	6m 12s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	branch-2.3 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 22s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	6m 17s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server generated 1 new + 26 unchanged - 0 fixed = 27 total (was 26)
		_ Other Tests _
+1 💚	unit	224m 21s	hbase-server in the patch passed.
		253m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bbaddb062828 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.3 / `6147c1c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/testReport/
Max. process+thread count	2769 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


          HBASE-25984: Avoid premature reuse of sync futures in FSHLog (apache#…

ace10fe

…3371)

Signed-off-by: Viraj Jasani <[email protected]>
(cherry picked from commit 5a19bcf)

bharathv force-pushed the HBASE-25984-branch-2.3 branch from a727cb6 to ace10fe Compare

June 17, 2021 19:26

bharathv merged commit 33f175f into apache:branch-2.3

bharathv deleted the HBASE-25984-branch-2.3 branch

June 17, 2021 19:29

Apache-HBase commented Jun 17, 2021

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
-1 ❌	patch	0m 6s	#3394 does not apply to branch-2.3. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase commented Jun 17, 2021

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 41s	Docker mode activated.
-1 ❌	patch	0m 6s	#3394 does not apply to branch-2.3. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase commented Jun 17, 2021

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
-1 ❌	patch	0m 6s	#3394 does not apply to branch-2.3. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3394
JIRA Issue	HBASE-25984
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3394/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet