HBASE-26001 When turn on access control, the cell level TTL of Increment and Append operations is invalid #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent and Append operations is invalid
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
It seems that the test failure is not related to the change. |
Contributor
|
Any related unit tests? |
Contributor
Author
|
Have added a related unit test. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Reidddddd
reviewed
Jun 16, 2021
| .collect(Collectors.toList()); | ||
| } | ||
| } | ||
| } |
Reidddddd
requested changes
Jun 16, 2021
| createTableWithCoprocessor(tableName, ChangeCellWithACLTagObserver.class.getName()); | ||
| try (Table table = connection.getTable(tableName)) { | ||
| // Append without TTL | ||
| Append firstAppend = new Append(ROW).addColumn(CF1_BYTES, CQ2, VALUE).setACL(new HashMap<>()); |
Contributor
There was a problem hiding this comment.
Is it possible we add a non-null empty acls? then after the 2nd increment, we verify whether the result has the carried-forward acls?
|
🎊 +1 overall
This message was automatically generated. |
Contributor
|
Please also pay attention to the checkstyle warnings. |
|
🎊 +1 overall
This message was automatically generated. |
Reidddddd
reviewed
Jun 16, 2021
| assertEquals(2, Bytes.toLong(result.getValue(CF1_BYTES, CQ1))); | ||
|
|
||
| // Wait 2s to let the second increment expire | ||
| Thread.sleep(2000); |
Contributor
There was a problem hiding this comment.
To improve the stability of the UT, I recommend to set the sleep time higher.
Contributor
Author
There was a problem hiding this comment.
Increase the sleep time to 10s.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Reidddddd
requested changes
Jun 16, 2021
| assertTrue(Bytes.equals(VALUE2, result.getValue(CF1_BYTES, CQ2))); | ||
|
|
||
| // Wait 2s to let the second append expire | ||
| Thread.sleep(2000); |
Contributor
Author
There was a problem hiding this comment.
Increased the sleep time to 10s
Reidddddd
approved these changes
Jun 17, 2021
Contributor
Reidddddd
left a comment
Reidddddd
left a comment
There was a problem hiding this comment.
+1. Let's wait for the QA result
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/projects/HBASE/issues/HBASE-26001