HBASE-26000 Optimize the display of ZK dump in the master web UI #3383

tomscut · 2021-06-13T07:16:21Z

Optimize the display of ZK dump in the master web UI.

Apache-HBase · 2021-06-13T07:45:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 56s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	8m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 47s	hbase-zookeeper in the patch passed.
		28m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 797bffd4da90 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ba6995e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/testReport/
Max. process+thread count	566 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-13T07:54:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	checkstyle	0m 14s	master passed
+1 💚	spotbugs	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 13s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	0m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		37m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux c48291dbb26c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ba6995e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-13T07:54:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 4s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	8m 57s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 45s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	9m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 50s	hbase-zookeeper in the patch passed.
		37m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4bd7d4c45d45 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ba6995e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/testReport/
Max. process+thread count	273 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Overall, looks good, just left a small remark.

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

Apache-HBase · 2021-06-15T02:03:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 41s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	8m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	8m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-zookeeper in the patch passed.
		30m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0e11cdce1155 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e551cd6`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/testReport/
Max. process+thread count	528 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-15T02:08:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 4s	master passed
+1 💚	compile	0m 21s	master passed
+1 💚	shadedjars	10m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 38s	the patch passed
+1 💚	compile	0m 23s	the patch passed
+1 💚	javac	0m 23s	the patch passed
+1 💚	shadedjars	10m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 48s	hbase-zookeeper in the patch passed.
		35m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0339f409f82d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e551cd6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/testReport/
Max. process+thread count	354 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-15T02:21:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 14s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 18s	master passed
+1 💚	spotbugs	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 44s	the patch passed
+1 💚	compile	0m 33s	the patch passed
+1 💚	javac	0m 33s	the patch passed
+1 💚	checkstyle	0m 13s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	23m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	0m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		48m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3383
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e5236bf077c1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e551cd6`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3383/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-06-15T06:08:31Z

Hi @Apache9 , could you please help review the code?

wchevreuil

LGTM

tomscut · 2021-06-15T08:40:04Z

Thanks @wchevreuil and @Apache9 for your review. Could you please help merge the code if there are no other problems?

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 555f8b4)

HBASE-26000 Optimize the display of ZK dump in the master web UI

3fac9e5

wchevreuil reviewed Jun 14, 2021

View reviewed changes

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Outdated Show resolved Hide resolved

remove redundant code

23e76fb

tomscut requested a review from wchevreuil June 15, 2021 06:08

wchevreuil approved these changes Jun 15, 2021

View reviewed changes

Apache9 approved these changes Jun 15, 2021

View reviewed changes

wchevreuil merged commit 555f8b4 into apache:master Jun 15, 2021

wchevreuil pushed a commit that referenced this pull request Jun 15, 2021

HBASE-26000 Optimize the display of ZK dump in the master web UI (#3383)

a238e79

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

wchevreuil pushed a commit that referenced this pull request Jun 15, 2021

HBASE-26000 Optimize the display of ZK dump in the master web UI (#3383)

49131fa

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 555f8b4)

wchevreuil pushed a commit that referenced this pull request Jun 15, 2021

HBASE-26000 Optimize the display of ZK dump in the master web UI (#3383)

6147c1c

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 555f8b4)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26000 Optimize the display of ZK dump in the master web UI #3383

HBASE-26000 Optimize the display of ZK dump in the master web UI #3383

Uh oh!

tomscut commented Jun 13, 2021 •

edited

Loading

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

wchevreuil left a comment

Uh oh!

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

wchevreuil left a comment

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-26000 Optimize the display of ZK dump in the master web UI #3383

HBASE-26000 Optimize the display of ZK dump in the master web UI #3383

Uh oh!

Conversation

tomscut commented Jun 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

Apache-HBase commented Jun 13, 2021

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

Apache-HBase commented Jun 15, 2021

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

wchevreuil left a comment

Choose a reason for hiding this comment

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tomscut commented Jun 13, 2021 •

edited

Loading