Skip to content

HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r… #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Apache9 merged 3 commits into from
Jun 27, 2021
Merged

HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r… #3374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6789b90
HBASE-25980 Master table.jsp pointed at meta throws 500 when no all r…
GeorryHuang Jun 10, 2021
f3cd437
explaining a bit more about the Exception catch
GeorryHuang Jun 12, 2021
fe21891
modify rit table info in details page
GeorryHuang Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions hbase-server/src/main/resources/hbase-webapps/master/table.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
import="org.apache.hadoop.hbase.master.http.MetaBrowser"
import="org.apache.hadoop.hbase.master.http.RegionReplicaInfo"
import="org.apache.hadoop.hbase.quotas.QuotaSettingsFactory"
import="org.apache.hadoop.hbase.quotas.QuotaTableUtil"%>
import="org.apache.hadoop.hbase.quotas.QuotaTableUtil"
import="org.apache.hadoop.hbase.NotAllMetaRegionsOnlineException" %>
<%@ page import="org.apache.hadoop.hbase.quotas.SpaceQuotaSnapshot" %>
<%@ page import="org.apache.hadoop.hbase.quotas.ThrottleSettings" %>
<%@ page import="org.apache.hadoop.hbase.util.Bytes" %>
Expand Down Expand Up @@ -313,8 +314,16 @@
for (int j = 0; j < numMetaReplicas; j++) {
RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
RegionInfoBuilder.FIRST_META_REGIONINFO, j);
ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
//If a metaLocation is null, All of its info would be empty here to be displayed.
ServerName metaLocation = null;
try {
metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
} catch (NotAllMetaRegionsOnlineException e) {
//Region in transition state here throw a NotAllMetaRegionsOnlineException causes
//the UI crash.
}
for (int i = 0; i < 1; i++) {
//If metaLocation is null, default value below would be displayed in UI.
String hostAndPort = "";
String readReq = "N/A";
String writeReq = "N/A";
Expand Down Expand Up @@ -378,8 +387,16 @@
for (int j = 0; j < numMetaReplicas; j++) {
RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
RegionInfoBuilder.FIRST_META_REGIONINFO, j);
ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
//If a metaLocation is null, All of its info would be empty here to be displayed.
ServerName metaLocation = null;
try {
metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
} catch (NotAllMetaRegionsOnlineException e) {
//Region in transition state here throw a NotAllMetaRegionsOnlineException causes
//the UI crash.
}
for (int i = 0; i < 1; i++) {
//If metaLocation is null, default value below would be displayed in UI.
String hostAndPort = "";
float locality = 0.0f;
float localityForSsd = 0.0f;
Expand Down Expand Up @@ -426,8 +443,16 @@
for (int j = 0; j < numMetaReplicas; j++) {
RegionInfo meta = RegionReplicaUtil.getRegionInfoForReplica(
RegionInfoBuilder.FIRST_META_REGIONINFO, j);
ServerName metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
//If a metaLocation is null, All of its info would be empty here to be displayed.
ServerName metaLocation = null;
try {
metaLocation = MetaTableLocator.waitMetaRegionLocation(master.getZooKeeper(), j, 1);
} catch (NotAllMetaRegionsOnlineException e) {
//Region in transition state here throw a NotAllMetaRegionsOnlineException causes
//the UI crash.
}
for (int i = 0; i < 1; i++) {
//If metaLocation is null, default value below would be displayed in UI.
String hostAndPort = "";
long compactingCells = 0;
long compactedCells = 0;
Expand Down