HBASE-25934 Add username for RegionScannerHolder #3325

tomscut · 2021-05-28T03:37:08Z

This JIRA HBASE-25542 has added part of the client information before, we can also add username for RegionScannerHolder.

saintstack

Just one comment. What you think? Otherwise, this would be a nice addition helping operators figure bad agents or problematic regions.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

Apache-HBase · 2021-05-28T04:29:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 20s	master passed
+1 💚	compile	3m 23s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotbugs	2m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	3m 20s	the patch passed
+1 💚	javac	3m 20s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		51m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e1e8bf46edd4 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed8df5e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-28T06:34:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 16s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	shadedjars	8m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	8m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
-1 ❌	unit	145m 55s	hbase-server in the patch failed.
		176m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1bc93f76f62b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed8df5e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/testReport/
Max. process+thread count	3900 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-28T06:59:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 31s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	8m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	163m 58s	hbase-server in the patch failed.
		201m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8c8d3b11d12a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ed8df5e`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/testReport/
Max. process+thread count	3765 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-05-28T07:18:57Z

Failed tests:
org.apache.hadoop.hbase.regionserver.TestWALLockup.(?) (Those failed unit tests are unrelated to the change, and they work fine locally)

org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream.testCleanClosedWALs (This failed unit test is also unrelated to the change)

saintstack · 2021-05-28T15:06:52Z

Agree the test failures look unrelated. Rerunning tests just to be sure.

Apache-HBase · 2021-05-28T16:03:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 34s	master passed
+1 💚	compile	3m 25s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotbugs	2m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 19s	the patch passed
+1 💚	compile	3m 33s	the patch passed
+1 💚	javac	3m 33s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		56m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux f72fe379bdb2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `479ae88`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-30T05:34:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 6s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	checkstyle	1m 10s	master passed
+1 💚	spotbugs	2m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	3m 21s	the patch passed
+1 💚	javac	3m 21s	the patch passed
+1 💚	checkstyle	1m 9s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 57s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		53m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 8ddc48e384c0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f119a86`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-30T07:49:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 28s	master passed
+1 💚	compile	1m 16s	master passed
+1 💚	shadedjars	8m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	8m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	156m 29s	hbase-server in the patch failed.
		189m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d94a1fa1a2fe 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f119a86`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/testReport/
Max. process+thread count	3817 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-30T08:44:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	1m 4s	master passed
+1 💚	shadedjars	9m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	9m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	211m 32s	hbase-server in the patch failed.
		244m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c37f4981af7c 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f119a86`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/testReport/
Max. process+thread count	3057 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-05-31T11:14:04Z

Hi @saintstack , those failed unit tests look unrelated to the change, and they work fine locally.

org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor5.testAppendWithoutWAL[1]
org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL
org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?)

Apache-HBase · 2021-06-01T18:22:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotbugs	2m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	3m 18s	the patch passed
+1 💚	javac	3m 18s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 53s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		51m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e9014d017c28 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `335305e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-01T21:34:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 18s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	9m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	9m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	210m 5s	hbase-server in the patch failed.
		242m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5ab70eebe42a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `335305e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/testReport/
Max. process+thread count	3205 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-06-03T03:33:33Z

Those failed unit tests work fine locally.

org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?)

tomscut · 2021-06-04T02:00:44Z

Those failed unit tests work fine locally.

org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?)

Hi @saintstack , could you please help to review it again? Thank you.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSRpcServices.java

Apache-HBase · 2021-06-08T08:18:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 8s	master passed
+1 💚	compile	3m 15s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotbugs	2m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	3m 16s	the patch passed
+1 💚	javac	3m 16s	the patch passed
+1 💚	checkstyle	1m 9s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 46s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		50m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1c393dbfe890 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be14605`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-08T10:24:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	1m 16s	master passed
+1 💚	shadedjars	8m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	8m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	143m 38s	hbase-server in the patch passed.
		176m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 358718e9baa5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be14605`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/testReport/
Max. process+thread count	3987 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-08T11:51:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 55s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	9m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	9m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	228m 37s	hbase-server in the patch passed.
		264m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c9bc43e9db3f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `be14605`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/testReport/
Max. process+thread count	3313 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-06-09T01:38:19Z

Hi @Apache9 , I fixed the problem you mentioned. Could you please take a look? Thank you.

tomscut · 2021-06-10T01:32:13Z

Hi @saintstack @Apache9 , could you please help me merge the code if there are no other problems. Thanks a lot.

tomscut · 2021-06-15T08:47:17Z

Hi @jojochuang , could you please do another review? Thank you.

tomscut · 2021-06-15T14:50:20Z

Hi @wchevreuil , could you please take a look at this PR if you have time? Thank you.

tomscut · 2021-06-19T11:26:24Z

Rebased to latest commit.

Apache-HBase · 2021-06-19T12:22:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	3m 21s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotbugs	2m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 39s	the patch passed
+1 💚	compile	3m 27s	the patch passed
+1 💚	javac	3m 27s	the patch passed
+1 💚	checkstyle	1m 25s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 18s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 43s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		55m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 27843c148bf2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f0a3959`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-19T14:12:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 10s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	8m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	8m 15s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	128m 43s	hbase-server in the patch failed.
		165m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 22d24e387501 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f0a3959`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/testReport/
Max. process+thread count	3867 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-06-19T14:12:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 55s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	8m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 43s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	8m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	132m 19s	hbase-server in the patch passed.
		166m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3325
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c7b1381549b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f0a3959`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/testReport/
Max. process+thread count	3554 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3325/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2021-06-21T03:23:39Z

org.apache.hadoop.hbase.TestJMXListener.(?)
org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas.xml.[failed-to-read]

These failed unit tests are unrelated to the change and work fine locally.

tomscut · 2021-06-21T03:24:50Z

Hi @nyl3532016 , could you please do another review? Thank you.

tomscut · 2021-06-21T11:19:41Z

Hi @virajjasani , could you please help to review the code? Thank you.

anoopsjohn · 2021-06-21T11:33:37Z

I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed?

tomscut · 2021-06-21T11:39:40Z

I see +1 already from @Apache9. Are we waiting for some one else's comments to be addressed?

Agree the test failures look unrelated. Rerunning tests just to be sure.

Hi @anoopsjohn , the problem @saintstack raised has been solved and the unit test has been run. Maybe he is too busy to review it again.

tomscut · 2021-06-23T01:28:23Z

Hi @jojochuang , could you please take a look at this? Thank you.

virajjasani

+1

tomscut · 2021-06-23T05:03:19Z

+1

Thanks @virajjasani for your review.

Apache9 · 2021-06-23T05:55:17Z

Sorry for the delay...

@virajjasani Please help merging this PR? I have a meeting soon.

Thanks.

tomscut · 2021-06-23T07:09:42Z

@virajjasani @Apache9 @saintstack @anoopsjohn Thank you.

Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

saintstack reviewed May 28, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java Show resolved Hide resolved

tomscut requested a review from saintstack June 2, 2021 09:28

Apache9 reviewed Jun 8, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java Show resolved Hide resolved

Apache9 reviewed Jun 8, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java Show resolved Hide resolved

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSRpcServices.java Show resolved Hide resolved

Apache9 approved these changes Jun 9, 2021

View reviewed changes

tomscut mentioned this pull request Jun 19, 2021

HDFS-16078. Remove unused parameters for DatanodeManager.handleLifeli… apache/hadoop#3119

Merged

HBASE-25934 Add username for RegionScannerHolder

66f3dd6

tomscut force-pushed the HBASE-25934 branch from e1d5a5b to 66f3dd6 Compare June 19, 2021 11:25

virajjasani approved these changes Jun 23, 2021

View reviewed changes

virajjasani merged commit fa2d127 into apache:master Jun 23, 2021

virajjasani pushed a commit that referenced this pull request Jun 23, 2021

HBASE-25934 Add username for RegionScannerHolder (#3325)

c81a5ab

Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request Jun 23, 2021

HBASE-25934 Add username for RegionScannerHolder (#3325)

8d1473d

Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

HBASE-25934 Add username for RegionScannerHolder #3325

HBASE-25934 Add username for RegionScannerHolder #3325

Uh oh!

Conversation

tomscut commented May 28, 2021

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented May 28, 2021

Uh oh!

Apache-HBase commented May 28, 2021

Uh oh!

Apache-HBase commented May 28, 2021

Uh oh!

tomscut commented May 28, 2021

Uh oh!

saintstack commented May 28, 2021

Uh oh!

Apache-HBase commented May 28, 2021

Uh oh!

Apache-HBase commented May 30, 2021

Uh oh!

Apache-HBase commented May 30, 2021

Uh oh!

Apache-HBase commented May 30, 2021

Uh oh!

tomscut commented May 31, 2021

Uh oh!

Apache-HBase commented Jun 1, 2021

Uh oh!

Apache-HBase commented Jun 1, 2021

Uh oh!

tomscut commented Jun 3, 2021

Uh oh!

tomscut commented Jun 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jun 8, 2021

Uh oh!

Apache-HBase commented Jun 8, 2021

Uh oh!

Apache-HBase commented Jun 8, 2021

Uh oh!

tomscut commented Jun 9, 2021

Uh oh!

tomscut commented Jun 10, 2021

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

tomscut commented Jun 15, 2021

Uh oh!

tomscut commented Jun 19, 2021

Uh oh!

Apache-HBase commented Jun 19, 2021

Uh oh!

Apache-HBase commented Jun 19, 2021

Uh oh!

Apache-HBase commented Jun 19, 2021

Uh oh!

tomscut commented Jun 21, 2021

Uh oh!

tomscut commented Jun 21, 2021

Uh oh!

tomscut commented Jun 21, 2021

Uh oh!

anoopsjohn commented Jun 21, 2021

Uh oh!

tomscut commented Jun 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomscut commented Jun 23, 2021

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

tomscut commented Jun 23, 2021

tomscut commented Jun 21, 2021 •

edited

Loading